66070[!!!][TASK] Make Extbase handle PSR-7 responses only
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 27
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92502-MakeExtbaseHandlePSR7ResponsesOnly.rstnew+57 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php2+2 −2
- typo3/sysext/extbase/Classes/Core/Bootstrap.php2+12 −32
- typo3/sysext/extbase/Classes/Event/Mvc/AfterRequestDispatchedEvent.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+39 −34
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php+0 −26
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerInterface.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Exception/StopActionException.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php+3 −3
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/RequestHandlerInterface.php+2 −0
- typo3/sysext/extbase/Classes/Mvc/Response.phpdeleted+0 −379
- typo3/sysext/extbase/Classes/Mvc/ResponseInterface.phpdeleted+0 −50
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/ContentController.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+6 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+7 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+4 −4
Show 7 more files
- typo3/sysext/extbase/Tests/Unit/Mvc/ResponseTest.phpdeleted+0 −81
- typo3/sysext/form/Classes/Controller/FormEditorController.php+3 −1
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php2+12 −4
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+3 −3
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+14 −12
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+8 −10
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+2 −2
Review log 2337
Show 612 earlier messages
-
Alexander Schnitzler uploaded patch set 1 10/07/20, 13:44
-
TYPO3com voted on patch set 1 V -1 10/07/20, 13:59 Completed build in 14m 47s on Wed, 7 Oct, 01:59 PM Test Summary: 5 of 74249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6324
-
TYPO3com commented on patch set 1 10/07/20, 14:20 Completed build in 51m 04s on Wed, 7 Oct, 02:20 PM Test Summary: 5 of 74249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6324
-
Alexander Schnitzler uploaded patch set 2 10/07/20, 14:20
-
Alexander Schnitzler wrote 10/07/20, 14:32
Topic set to extbase -
TYPO3com voted on patch set 2 V -1 10/07/20, 14:36 Completed build in 15m 47s on Wed, 7 Oct, 02:36 PM Test Summary: 5 of 74249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6325
-
Alexander Schnitzler uploaded patch set 3 10/07/20, 14:52
-
TYPO3com voted on patch set 3 V -1 10/07/20, 15:04 Completed build in 12m 16s on Wed, 7 Oct, 03:04 PM Test Summary: 17 of 74249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6329
-
Alexander Schnitzler uploaded patch set 4 10/07/20, 16:04
-
TYPO3com voted on patch set 4 V -1 10/07/20, 16:17 Completed build in 13m 06s on Wed, 7 Oct, 04:17 PM Test Summary: 97 of 65814 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6330
-
Alexander Schnitzler uploaded patch set 5 10/23/20, 13:12
-
TYPO3com voted on patch set 5 V -1 10/23/20, 13:24 Completed build in 12m 33s on Fri, 23 Oct, 01:24 PM Test Summary: 102 of 73919 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6844
-
Alexander Schnitzler uploaded patch set 6 10/29/20, 09:06
-
TYPO3com voted on patch set 6 V -1 10/29/20, 09:06 Completed build in 23s on Thu, 29 Oct, 09:06 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6985
-
Alexander Schnitzler uploaded patch set 7 10/29/20, 09:21
-
Alexander Schnitzler wrote 10/29/20, 09:21
Hashtag added: PSR-7 -
TYPO3com voted on patch set 7 V -1 10/29/20, 09:32 Completed build in 11m 26s on Thu, 29 Oct, 09:32 AM Test Summary: 21 of 74015 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6986
-
Alexander Schnitzler uploaded patch set 8 10/29/20, 10:16
-
TYPO3com voted on patch set 8 V -1 10/29/20, 10:27 Completed build in 11m 19s on Thu, 29 Oct, 10:27 AM Test Summary: 15 of 74015 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6989
-
Alexander Schnitzler uploaded patch set 9 10/29/20, 10:29
-
TYPO3com voted on patch set 9 V +1 10/29/20, 10:41 Completed build in 11m 20s on Thu, 29 Oct, 10:41 AM Test Summary: 73524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6990
-
Alexander Schnitzler uploaded patch set 10 10/29/20, 11:10
-
TYPO3com voted on patch set 10 V -1 10/29/20, 11:23 Completed build in 12m 53s on Thu, 29 Oct, 11:23 AM Test Summary: 6 of 74009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6997
-
TYPO3com voted on patch set 10 V +1 10/29/20, 11:33 Completed build in 34m 51s on Thu, 29 Oct, 11:33 AM Test Summary: 73524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6997
-
Alexander Schnitzler commented on patch set 10 10/29/20, 11:41
This change is ready for review. -
Oliver Klee commented on patch set 10 CR -1 10/29/20, 12:00
AbstractController.php:40This needs to be @return, not @param, and without the $response. (Looks like a copy'n'paste error to me.) -
Alexander Schnitzler commented on patch set 10 10/29/20, 12:06
AbstractController.php:40Reply UnresolvedIndeed. I rebased many times and this is the result. Will push another patch set later. -
Alexander Schnitzler uploaded patch set 11 10/29/20, 12:52
-
TYPO3com voted on patch set 11 V +1 10/29/20, 13:04 Completed build in 11m 44s on Thu, 29 Oct, 01:04 PM Test Summary: 73524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7001
-
Benni Mack commented on patch set 11 10/29/20, 14:18
Bootstrap.php:200this is bad, but I see / know why you have to do this... This sounds like a lot of problems because the default PSR-7 response object of TYPO3-Core probably sends headers... maybe we can find a workaround here.RedirectFinisher.php:130should we put the response in the exception? -
Alexander Schnitzler commented on patch set 11 10/29/20, 15:39
Bootstrap.php:200Reply UnresolvedThis code is actually just copied from former \TYPO3\CMS\Extbase\Mvc\Response::sendHeaders() which sent the headers on shutdown(). I know that sending headers here is bad and I would like to avoid it but I don't know how a workaround should look like here.RedirectFinisher.php:130Reply UnresolvedWell, yeah. Maybe? Don't really know. ^^ Doesn't hurt I guess. -
Alexander Schnitzler uploaded patch set 12 11/05/20, 14:08
-
Alexander Schnitzler commented on patch set 12 11/05/20, 14:11
I set up an instance and tested the form framework stuff. I don't know all possiblities but I managed to check all places that are touched with xdebug breakpoints. In fact things were broken and last PS fixed those. -
TYPO3com voted on patch set 12 V +1 11/05/20, 14:21 Completed build in 12m 20s on Thu, 5 Nov, 02:21 PM Test Summary: 73563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7132
-
Benni Mack voted on patch set 12 V +1 CR +1 11/05/20, 14:43
-
Daniel Goerz voted on patch set 12 V +2 CR +2 11/06/20, 08:51
-
Daniel Goerz merged patch set 13 11/06/20, 08:51