Review main Abandoned

66073[FEATURE] enable preload for stylesheets

Marcel Tams CR 0 V 0 Easy +4 −2 updated 08/01/24, 11:19

Commit message

you can now set the preload property on entries in the includeCSS
array.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 89

  1. Marcel Tams uploaded patch set 1 10/07/20, 16:41

  2. TYPO3com voted on patch set 1 V +1 10/07/20, 16:55 Completed build in 13m 45s on Wed, 7 Oct, 04:55 PM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6332

  3. Marcel Tams wrote 10/07/20, 16:57

    Assignee added: Christoph Lehmann <christoph.lehmann@networkteam.com>
  4. Christoph Lehmann commented on patch set 1 10/07/20, 20:00

    PageRenderer.php:1246 Unresolved

    The PHPDoc block needs the new parameter too

    PageRenderer.php:1262 Unresolved

    On a short search i just found rel="preload", not preload as attribute itself. Also in https://html.spec.whatwg.org/multipage/semantics.html#the-link-element it's not mentioned, so i think you need to modify "rel" and "as", or?
  5. Marcel Tams wrote 10/07/20, 20:05

    Assignee deleted: Christoph Lehmann <christoph.lehmann@networkteam.com>
  6. Marcel Tams marked it work in progress 10/07/20, 20:18

  7. Benni Mack wrote 11/29/21, 10:04

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 2 11/29/21, 13:23

  9. Anja Leichsenring abandoned the change 08/01/24, 11:19

    I take the freedom to abandon this WIP patch with last activity 2 years before. Should there still be interest, please feel free to restore.