Review main Merged

66076[TASK] Force integer for specific fields of site configuration

Georg Ringer CR +2 V +2 Easy +2 −0 updated 10/08/20, 06:16

Commit message

If the site config is saved through the site module the following fields
are saved as integer instead of a string:

- `languageId` of a language item
- `errorCode of an errorHandling item

This change makes it easier to lint the yaml configuration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Georg Ringer uploaded patch set 1 10/07/20, 20:14

  2. Georg Ringer commented on patch set 1 10/07/20, 20:14

    This change is ready for review.
  3. Georg Ringer uploaded patch set 2 10/07/20, 20:36

  4. TYPO3com voted on patch set 1 V +1 10/07/20, 20:41 Completed build in 21m 35s on Wed, 7 Oct, 08:41 PM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6341

  5. TYPO3com voted on patch set 2 V +1 10/07/20, 20:53 Completed build in 17m 13s on Wed, 7 Oct, 08:53 PM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6342

  6. Josef Glatz voted on patch set 2 V +1 CR +1 10/08/20, 04:15

  7. Benni Mack voted on patch set 2 V +2 CR +2 10/08/20, 06:16

  8. Benni Mack merged patch set 3 10/08/20, 06:16