Review main Merged

66077[TASK] Explicitly require PHPUnit 8

Helmut Hummel CR +2 V +2 Easy +17 −6 updated 10/08/20, 12:00

Commit message

The code in the test suite is based on PHPUnit 8
therefore using it with PHPUnit 9 will produce a lot of warnings
caused by deprecations.

The testing framework however allows installing PHPUnit 9,
which is fine, when the test suite itself can cope with that.

This is why we pin our tests to PHPUnit 8, until we adapt
them to properly work with PHPUnit 9

composer req --dev phpunit/phpunit ^8.5.2

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Helmut Hummel uploaded patch set 1 10/07/20, 20:44

  2. TYPO3com voted on patch set 1 V +1 10/07/20, 21:02 Completed build in 17m 24s on Wed, 7 Oct, 09:02 PM Test Summary: 73786 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6343

  3. Simon Gilli commented on patch set 1 CR -1 10/07/20, 21:43

    composer.json:51 Unresolved

    Should be a dev dependency
  4. Simon Gilli uploaded patch set 2 10/07/20, 22:35

  5. TYPO3com voted on patch set 2 V -1 10/07/20, 22:35 Completed build in 26s on Wed, 7 Oct, 10:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6344

  6. Simon Gilli uploaded patch set 3 10/07/20, 22:36

  7. Simon Gilli voted on patch set 3 V +1 CR +1 10/07/20, 22:37

  8. TYPO3com voted on patch set 3 V +1 10/07/20, 22:50 Completed build in 13m 59s on Wed, 7 Oct, 10:50 PM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6345

  9. Benni Mack voted on patch set 3 V +2 CR +2 10/08/20, 07:39

  10. Oliver Klee voted on patch set 3 CR +1 10/08/20, 09:11

  11. Helmut Hummel merged patch set 4 10/08/20, 12:00