66079[!!!][TASK] Request processing chain must return a response object
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 17
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+4 −3
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst7new+37 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php+3 −3
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php8+12 −8
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerInterface.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Exception/StopActionException.php+17 −0
- typo3/sysext/extbase/Classes/Mvc/Web/BackendRequestHandler.php+1 −3
- typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php+2 −6
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php3+12 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/ContentController.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+4 −12
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+3 −11
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+2 −10
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+2 −3
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+3 −3
Review log 2433
Show 48 earlier messages
-
Alexander Schnitzler uploaded patch set 1 10/08/20, 06:20
-
Alexander Schnitzler uploaded patch set 2 10/08/20, 06:33
-
TYPO3com voted on patch set 1 V -1 10/08/20, 06:37 Completed build in 16m 21s on Thu, 8 Oct, 06:37 AM Test Summary: 1 of 65838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6347
-
TYPO3com voted on patch set 2 V -1 10/08/20, 06:51 Completed build in 17m 31s on Thu, 8 Oct, 06:51 AM Test Summary: 58 of 74273 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6348
-
Alexander Schnitzler uploaded patch set 3 10/08/20, 07:01
-
TYPO3com voted on patch set 3 V -1 10/08/20, 07:17 Completed build in 15m 41s on Thu, 8 Oct, 07:17 AM Test Summary: 7 of 74273 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6349
-
Alexander Schnitzler uploaded patch set 4 10/08/20, 07:32
-
TYPO3com voted on patch set 4 V +1 10/08/20, 07:48 Completed build in 15m 39s on Thu, 8 Oct, 07:48 AM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6351
-
Alexander Schnitzler wrote 10/08/20, 07:52
Topic set to extbase -
Alexander Schnitzler wrote 10/08/20, 07:52
Hashtag added: PSR-7 -
Alexander Schnitzler uploaded patch set 5 10/08/20, 09:35
-
TYPO3com voted on patch set 5 V +1 10/08/20, 09:46 Completed build in 11m 40s on Thu, 8 Oct, 09:46 AM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6354
-
Alexander Schnitzler commented on patch set 5 10/08/20, 09:47
This change is ready for review. -
Benni Mack uploaded patch set 6 10/12/20, 14:43
-
TYPO3com voted on patch set 6 V +1 10/12/20, 14:56 Completed build in 12m 52s on Mon, 12 Oct, 02:56 PM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6447
-
Alexander Schnitzler uploaded patch set 7 10/20/20, 12:59
-
TYPO3com voted on patch set 7 V +1 10/20/20, 13:12 Completed build in 13m 06s on Tue, 20 Oct, 01:12 PM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6692
-
Alexander Schnitzler commented on patch set 7 CR -1 10/20/20, 13:15
Breaking-92513-StopActionExceptionRequiresAResponseObjectAsConstructorArgument.rst:12- nor -> now. - it's not the first argument any more since one of the recent patch sets. -
Benni Mack commented on patch set 7 10/20/20, 13:42
ActionController.php:416do we need these three lines? Response should have setRequest() at any time now. -
Alexander Schnitzler commented on patch set 7 10/20/20, 14:41
ActionController.php:416Reply UnresolvedI woudn't drop it until we merge this change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66070/4/typo3/sysext/extbase/Classes/Mvc/Response.php#b358 -
Benni Mack commented on patch set 7 10/20/20, 19:34
Breaking-92513-StopActionExceptionRequiresAResponseObjectAsConstructorArgument.rst:12Reply UnresolvedIMHO we can remove this specific RST now -
Alexander Schnitzler uploaded patch set 8 10/21/20, 10:02
-
TYPO3com voted on patch set 8 V +1 10/21/20, 10:16 Completed build in 13m 48s on Wed, 21 Oct, 10:16 AM Test Summary: 73486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6714
-
Benni Mack voted on patch set 8 V +1 CR +1 10/23/20, 07:42
-
Oli Bartsch commented on patch set 8 10/23/20, 08:09
Breaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst:12Suggest to use the fully qualified name here `TYPO3\CMS\Extbase\Mvc\ResponseInterface` to make it clear.Breaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst:33Also here: "Return a :php:`TYPO3\CMS\Extbase\Mvc\ResponseInterface` object" (Without the full stop according to the other bullet point)ActionController.php:398This should be changed as the response object is no longer given to this function. Same in the interfaceActionController.php:407Just curios, why do we use objectManager->get here instead of DI or makeInstance?Dispatcher.php:98Same question, why using objectManager here? -
Alexander Schnitzler commented on patch set 8 10/23/20, 08:18
Breaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst:12ReplyThat I wouldn't do because there is another patch pending which removes that interface. The goal is to be PSR-7 compatible and use the ResponseInterface of that package. I would rather adjust this rst file after that mentioned change has been merged.Breaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst:33ReplySame here.ActionController.php:398ReplyDoog catch!ActionController.php:407ReplyLet's use makeInstance here. That's a copy paste issue.Dispatcher.php:98ReplyThat's just copy paste stuff. We can use makeInstance here already since Response does not have any dependencies. -
Oli Bartsch commented on patch set 8 10/23/20, 08:29
Breaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst:12ReplyGreat, sounds even better. -
Alexander Schnitzler uploaded patch set 9 10/23/20, 11:44
-
Alexander Schnitzler commented on patch set 9 10/23/20, 11:45
Breaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst:12ReplyDoneBreaking-92513-MethodSignatureChangeOfTYPO3CMSExtbaseMvcControllerControllerInterfaceprocessRequest.rst:33ReplyDoneActionController.php:398ReplyDoneActionController.php:407ReplyDoneDispatcher.php:98ReplyDone -
TYPO3com voted on patch set 9 V +1 10/23/20, 11:57 Completed build in 12m 57s on Fri, 23 Oct, 11:57 AM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6838
-
Oli Bartsch voted on patch set 9 V +1 CR +1 10/23/20, 12:37
-
Benni Mack voted on patch set 9 V +2 CR +2 10/23/20, 12:38
-
Benni Mack merged patch set 10 10/23/20, 12:38