66080[FEATURE] Make PSR-7 Request available in ContentObjectRenderer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 24
- typo3/sysext/core/Documentation/Changelog/master/Feature-92984-PSR-7RequestAvailableInFrontendContentObjects.rstnew+55 −0
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+4 −3
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+6 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php+8 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php6+37 −3
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php2+14 −10
- typo3/sysext/frontend/Classes/DataProcessing/DatabaseQueryProcessor.php+2 −1
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+2 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+2 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+3 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+3 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+2 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+3 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/FilesContentObjectTest.php+2 −0
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+2 −1
Review log 2845
Show 1020 earlier messages
-
Benni Mack uploaded patch set 1 10/08/20, 10:09
-
TYPO3com voted on patch set 1 V -1 10/08/20, 10:25 Completed build in 15m 28s on Thu, 8 Oct, 10:25 AM Test Summary: 2561 of 74273 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6356
-
Benni Mack uploaded patch set 2 10/09/20, 07:36
-
TYPO3com voted on patch set 2 V +1 10/09/20, 07:50 Completed build in 13m 08s on Fri, 9 Oct, 07:50 AM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6389
-
Benni Mack uploaded patch set 3 10/27/20, 09:27
-
TYPO3com voted on patch set 3 V -1 10/27/20, 09:38 Completed build in 11m 20s on Tue, 27 Oct, 09:38 AM Test Summary: 6 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6902
-
Benni Mack uploaded patch set 4 11/04/20, 22:27
-
TYPO3com voted on patch set 4 V -1 11/04/20, 22:40 Completed build in 12m 18s on Wed, 4 Nov, 10:40 PM Test Summary: 6 of 74078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7121
-
Benni Mack uploaded patch set 5 11/07/20, 14:55
-
TYPO3com voted on patch set 5 V +1 11/07/20, 15:09 Completed build in 14m 39s on Sat, 7 Nov, 03:09 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7174
-
Benni Mack updated the commit message in patch set 6 12/04/20, 07:17
-
TYPO3com voted on patch set 6 V +1 12/04/20, 07:27 Completed build in 10m 31s on Fri, 4 Dec, 07:27 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7769
-
Benni Mack uploaded patch set 7 12/04/20, 08:29
-
Benni Mack uploaded patch set 8 12/04/20, 08:33
-
TYPO3com voted on patch set 7 V -1 12/04/20, 08:39 Completed build in 09m 55s on Fri, 4 Dec, 08:39 AM Test Summary: 1 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7771
-
TYPO3com voted on patch set 8 V -1 12/04/20, 09:40 Completed build in 1h 06m 44s on Fri, 4 Dec, 09:40 AM Test Summary: 1457 of 23983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7772
-
Benni Mack rebased onto patch set 9 12/04/20, 12:22
-
TYPO3com voted on patch set 9 V -1 12/04/20, 13:29 Completed build in 1h 06m 51s on Fri, 4 Dec, 01:29 PM Test Summary: 1457 of 23983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7781
-
Benni Mack uploaded patch set 10 12/04/20, 15:03
-
TYPO3com voted on patch set 10 V +1 12/04/20, 15:16 Completed build in 09m 24s on Fri, 4 Dec, 03:16 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7788
-
Alexander Schnitzler commented on patch set 10 V -1 12/05/20, 11:17
-
Alexander Schnitzler uploaded patch set 11 12/05/20, 11:24
-
Alexander Schnitzler commented on patch set 11 V +1 CR +1 12/05/20, 11:25
ContentObjectRenderer.php:552ReplyDone -
TYPO3com voted on patch set 11 V +1 12/05/20, 11:33 Completed build in 09m 15s on Sat, 5 Dec, 11:33 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7822
-
Benjamin Franzke commented on patch set 11 V -1 CR -1 12/05/20, 12:44
ContentObjectRenderer.php:551We need to fallback to $GLOBALS['TYPO3_REQUEST'] here, because per RST file "the request is handed into all ContentObjects" and in case ContentObjectRenderer is invoked without an additional `setRequest()`, then `$this->request` is null and so will the ContentObjects get a null request as well. Verified that Request is null in RecordsContentObject with a CType=shortcut content element.ContentObjectRenderer.php:5195We probably need to fallback to $GLOBALS['TYPO3_REQUEST'] here, because per RST file the userfunc signature is not using a nullable ServerRequestInterface. To avoid BC problems when a userfunc uses the third parameter, but ContentObjectRenderer is invoked without `setRequest()`, a fallback would be needed. -
Benjamin Franzke uploaded patch set 12 12/05/20, 13:25
-
Benjamin Franzke commented on patch set 12 CR +1 12/05/20, 13:26
ContentObjectRenderer.php:551ReplyFallback now provided in getRequest().ContentObjectRenderer.php:5195ReplyDone -
TYPO3com voted on patch set 12 V -1 12/05/20, 13:34 Completed build in 08m 42s on Sat, 5 Dec, 01:34 PM Test Summary: 9 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7829
-
Benjamin Franzke uploaded patch set 13 12/05/20, 14:41
-
TYPO3com voted on patch set 13 V +1 12/05/20, 14:53 Completed build in 11m 30s on Sat, 5 Dec, 02:53 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7831
-
Benni Mack commented on patch set 13 V +1 CR +1 12/05/20, 18:58
fine with me like that. Thanks for the work! -
Benjamin Franzke commented on patch set 13 CR -1 12/05/20, 19:15
still on it, found some more cases -
Benjamin Franzke uploaded patch set 14 12/05/20, 19:22
-
Benjamin Franzke commented on patch set 14 12/05/20, 19:22
TypoScriptFrontendController.php:2914With the ContentObjectRenderer::getRequest() code I added in patchset 13 this is no longer needed. I think it's good that users of ContentObjectRenderer only inject request if they have an *own* reference. Injecting the global one is unneeded, as the global can be used by ContentObjectRenderer as fallback anyway. -
Benni Mack commented on patch set 14 12/05/20, 19:32
TypoScriptFrontendController.php:2914Replyk -
TYPO3com voted on patch set 14 V -1 12/05/20, 19:34 Completed build in 11m 23s on Sat, 5 Dec, 07:34 PM Test Summary: 6 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7834
-
TYPO3com commented on patch set 14 12/05/20, 19:50 Completed build in 10m 00s on Sat, 5 Dec, 07:50 PM Test Summary: 31329 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7836
-
TYPO3com voted on patch set 14 V +1 12/05/20, 20:01 Completed build in 09m 26s on Sat, 5 Dec, 08:01 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7837
-
Alexander Schnitzler voted on patch set 14 V +1 CR +1 12/05/20, 20:30
-
Benni Mack commented on patch set 15 12/05/20, 20:32
Published edit on patch set 14. -
TYPO3com voted on patch set 15 V +1 12/05/20, 20:41 Completed build in 09m 00s on Sat, 5 Dec, 08:41 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7838
-
Benjamin Franzke voted on patch set 15 V +1 CR +1 12/05/20, 20:42
-
Alexander Schnitzler voted on patch set 15 V +1 CR +1 12/05/20, 20:46
-
Benni Mack voted on patch set 15 V +2 CR +2 12/05/20, 20:52
-
Benni Mack merged patch set 16 12/05/20, 20:52
ContentObjectRenderer.php:552