Review 10.4 Merged

66081[BUGFIX] Limit doctrine/dbal to 2.10.x or 2.11.2+

Markus Klein CR +2 V +2 Normal +103 −16 updated 10/22/20, 15:24

Commit message

Version 2.11.0 and 2.11.1 contain breaking changes.
In order to ensure smooth operation of Core and
extensions, the version is now limited to
2.10.x and 2.11.2+

composer req doctrine/dbal "~2.10.0 || ~2.11.2"

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2837

Show 712 earlier messages
  1. Markus Klein uploaded patch set 1 10/08/20, 11:26

  2. TYPO3com voted on patch set 1 V +1 10/08/20, 11:39 Completed build in 12m 24s on Thu, 8 Oct, 11:39 AM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-598

  3. Simon Gilli voted on patch set 1 V +1 CR +1 10/08/20, 11:54

  4. Markus Klein uploaded patch set 2 10/08/20, 12:16

  5. Markus Klein voted on patch set 2 CR -1 10/08/20, 12:17

  6. Georg Ringer commented on patch set 2 CR -1 10/08/20, 12:17

    IMO we should better wait on a final fix on doctrine/dbal side, I doubt we do an extra release for that?!
  7. Markus Klein uploaded patch set 3 10/08/20, 12:18

  8. Markus Klein commented on patch set 3 10/08/20, 12:32

    > Patch Set 2: Code-Review-1 > > IMO we should better wait on a final fix on doctrine/dbal side, I doubt we do an extra release for that?! Developing with 2.11 is also "hell". PHPstorm marks all ->fetch() calls as deprecated.
  9. TYPO3com voted on patch set 3 V +1 10/08/20, 12:33 Completed build in 14m 15s on Thu, 8 Oct, 12:33 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-601

  10. TYPO3com voted on patch set 2 V +1 10/08/20, 12:36 Completed build in 18m 11s on Thu, 8 Oct, 12:36 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-600

  11. TYPO3com voted on patch set 3 V -1 10/08/20, 15:41 Completed build in 26s on Thu, 8 Oct, 03:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-49

  12. TYPO3com commented on patch set 3 10/08/20, 15:42 Completed build in 25s on Thu, 8 Oct, 03:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-50

  1. Markus Klein rebased onto patch set 4 10/10/20, 19:57

  2. TYPO3com voted on patch set 4 V +1 10/10/20, 20:09 Completed build in 11m 52s on Sat, 10 Oct, 08:09 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-611

  3. Oliver Klee voted on patch set 4 CR +1 10/11/20, 10:15

  4. Georg Ringer commented on patch set 4 CR -1 10/12/20, 09:08

  5. Josef Glatz commented on patch set 4 10/14/20, 05:39

  6. Benni Mack uploaded patch set 5 10/15/20, 09:53

  7. TYPO3com voted on patch set 5 V +1 10/15/20, 10:11 Completed build in 17m 54s on Thu, 15 Oct, 10:11 AM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-626

  8. Christian Kuhn commented on patch set 5 10/19/20, 20:01

    Is this patch still needed with 2.11.2 being released?
  9. Georg Ringer commented on patch set 5 10/19/20, 20:17

    I would add the problematic releases as conflicting, doesn't harm and helps a lot to avoid possible issues
  10. Christian Kuhn commented on patch set 5 10/20/20, 09:41

    Does it make sense to conflict with patch level releases that have been fixed? 2.11 is young, not many instances upgraded to it, yet. If they upgrade now, they would get latest patch level, which is ok. Feels a bit like needless bloat to conflict with 2.11.0 and 2.11.1 now. OTOH, I have no strong opinion and for sure wouldn't block it. What's your thought on this?
  11. Markus Klein commented on patch set 5 10/20/20, 10:26

    > Patch Set 5: > > Does it make sense to conflict with patch level releases that have been fixed? > 2.11 is young, not many instances upgraded to it, yet. If they upgrade now, they would get latest patch level, which is ok. > Feels a bit like needless bloat to conflict with 2.11.0 and 2.11.1 now. > OTOH, I have no strong opinion and for sure wouldn't block it. What's your thought on this? Well, if some other package requires 2.11.0 now, it would help to have it conflicting, then you would know upfront that things will not work as intended. Other option would be to declare 2.10.x || > 2.11.1
  12. Daniel Haupt commented on patch set 5 10/20/20, 12:54

    What about adding the conflicts to the LTS versions and declaring >= 2.11.2 for current master?
  13. Helmut Hummel commented on patch set 5 10/21/20, 14:01

    Since it isn't the first time we ran into trouble with doctrine minor updates I'd go for: "~2.10.0 || ~2.11.2" as version constraint (and maybe indeed only "~2.11.2" for latest) This is a more conservative approach. It will ptentially prevent issues in the future, but also means of course that we will need to update the constraint more often.
  14. Markus Klein uploaded patch set 6 10/21/20, 14:21

  15. Markus Klein commented on patch set 6 10/21/20, 14:22

    Should we do it for master now too?
  16. TYPO3com voted on patch set 6 V -1 10/21/20, 14:35 Completed build in 13m 10s on Wed, 21 Oct, 02:35 PM Test Summary: 1 of 75336 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-659

  17. Oliver Klee commented on patch set 6 10/21/20, 14:43

    composer.json:43

    Didn't we want to have a "conflict" entry instead?
  18. Markus Klein commented on patch set 6 10/21/20, 14:59

    composer.json:43 Reply Unresolved

    I followed Helmut's suggestion
  19. TYPO3com voted on patch set 6 V +1 10/21/20, 15:28 Completed build in 11m 26s on Wed, 21 Oct, 03:28 PM Test Summary: 74850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-660

  20. Daniel Haupt voted on patch set 6 V +1 CR +1 10/21/20, 15:58

  21. Georg Ringer voted on patch set 6 V +1 CR +1 10/22/20, 09:38

  22. Josef Glatz voted on patch set 6 V +1 CR +1 10/22/20, 15:16

  23. Christian Kuhn commented on patch set 6 10/22/20, 15:24

    i guess for master we could skip this: 11.0 has not been released and people upgrading would later have latest doctrine patch level anyway ...
  24. Christian Kuhn voted on patch set 6 V +2 CR +2 10/22/20, 15:24

  25. Christian Kuhn merged patch set 7 10/22/20, 15:24