Review 10.4 Merged

66082[TASK] Explicitly require PHPUnit 8

Helmut Hummel CR +2 V +2 Normal +115 −27 updated 10/08/20, 12:21

Commit message

The code in the test suite is based on PHPUnit 8
therefore using it with PHPUnit 9 will produce a lot of warnings
caused by deprecations.

The testing framework however allows installing PHPUnit 9,
which is fine, when the test suite itself can cope with that.

This is why we pin our tests to PHPUnit 8, until we adapt
them to properly work with PHPUnit 9

composer req --dev phpunit/phpunit ^8.5.2 --no-update
composer update phpunit/phpunit

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2

Issues 1

Files 2

Review log 34

  1. Helmut Hummel uploaded patch set 1 10/08/20, 12:06

  2. Helmut Hummel voted on patch set 1 V +2 CR +2 10/08/20, 12:07

  3. Helmut Hummel merged patch set 2 10/08/20, 12:07

  4. TYPO3com voted on patch set 1 V +1 10/08/20, 12:21 Completed build in 15m 00s on Thu, 8 Oct, 12:21 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-599