66083[FEATURE] Overrule namespace configuration in ExtbasePluginEnhancer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Gorges +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2231
Show 56 earlier messages
-
Daniel Siepmann uploaded patch set 1 10/08/20, 12:36
-
Markus Klein voted on patch set 1 CR +1 10/08/20, 12:42
-
Daniel Siepmann wrote 10/08/20, 12:45
Topic set to extbase -
TYPO3com voted on patch set 1 V +1 10/08/20, 12:52 Completed build in 16m 15s on Thu, 8 Oct, 12:52 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6366
-
Mathias Brodala commented on patch set 1 CR +1 11/03/20, 14:46
Of course it would be nice if the enhancer would use ExtensionService::getPluginNamespace() instead but then we'd have an ugly dependency on TypoScript again. -
Benni Mack voted on patch set 1 CR +1 11/03/20, 16:35
-
Daniel Siepmann commented on patch set 1 11/04/20, 08:14
If ok, I would opt for abandon the patch. The feature is already in and properly documented at: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Routing/AdvancedRoutingConfiguration.html?highlight=extbase%20enhancer#extbase-plugin-enhancer With existing code, one only needs to set namespace and no plugin and extension. That way it would work exactly as expected. That patch would only force the namespace if it would be configured in addition. Not sure what you think. -
Daniel Siepmann abandoned the change 11/04/20, 08:22
Change is not necessary, feature is already documented and available. -
Daniel Siepmann restored the change 11/04/20, 08:23
-
Daniel Siepmann updated the commit message in patch set 2 11/04/20, 08:24
-
Alexander Schnitzler commented on patch set 2 11/04/20, 08:31
Don't want to be the bad guy here but are you sure this works with multiple plugins and urls are properly built with the UriBuilder? And is it possible to have a functional test for this? -
TYPO3com voted on patch set 2 V +1 11/04/20, 08:41 Completed build in 16m 36s on Wed, 4 Nov, 08:41 AM Test Summary: 73585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7107
-
Daniel Siepmann uploaded patch set 3 11/04/20, 10:45
-
TYPO3com voted on patch set 3 V +1 11/04/20, 10:57 Completed build in 12m 03s on Wed, 4 Nov, 10:57 AM Test Summary: 73585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7109
-
Daniel Siepmann rebased onto patch set 4 04/30/21, 05:36
-
core-ci voted on patch set 4 V +1 04/30/21, 05:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10956
-
Benni Mack wrote 11/29/21, 10:06
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 5 11/29/21, 13:21
-
core-ci voted on patch set 5 V +1 11/29/21, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20004
-
Benni Mack rebased onto patch set 6
V +112/21/22, 08:02 -
core-ci voted on patch set 6 V -1 12/21/22, 08:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35261
-
Benni Mack commented on patch set 7
V -112/21/22, 08:26Published edit on patch set 6. -
core-ci voted on patch set 7 V -1 12/21/22, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35262
-
Benni Mack uploaded patch set 8
V -112/21/22, 09:51 -
core-ci voted on patch set 8 V -1 12/21/22, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35263
-
Benni Mack commented on patch set 9
V -112/21/22, 10:01Published edit on patch set 8. -
core-ci voted on patch set 9 V +1 12/21/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35264
-
Daniel Gorges voted on patch set 9 CR +1 12/21/22, 10:19
-
Andreas Kienast voted on patch set 9 V +1 CR +1 12/21/22, 10:35
-
Benni Mack voted on patch set 9 V +2 CR +2 12/21/22, 10:36
-
Benni Mack merged patch set 10 12/21/22, 10:36