66084[FEATURE] Add download and filename options to FileDumpController
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
- Richard Haeser +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/core/Classes/Controller/FileDumpController.php4+18 −4
- typo3/sysext/core/Documentation/Changelog/master/Feature-92518-DownloadAndFilenameOptionsAddedToFileDumpController.rst2new+48 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-92518-IntroduceFileViewHelper.rstnew+59 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php4new+178 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Folders/fileadmin/user_upload/typo3_image2.jpgnewbinary
- typo3/sysext/fluid/Tests/Functional/Fixtures/Folders/fileadmin/_processed_/csm_typo3_image2_5c2670fd59.jpgnewbinary
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Fixtures/Link/DatabaseImport.xmlnew+66 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Fixtures/Link/FileViewHelper.htmlnew+15 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/FileViewHelperTest.phpnew+266 −0
Review log 3349
Show 1524 earlier messages
-
Christian Eßl uploaded patch set 1 10/08/20, 14:12
-
Markus Klein commented on patch set 1 10/08/20, 14:14
-
Markus Klein updated the commit message in patch set 2 10/08/20, 14:14
-
Markus Klein commented on patch set 2 10/08/20, 14:16
FileDumpController.php:155shouldn't we exclude this from the token validation, so this parameter can be always appended or removed? -
Christian Eßl commented on patch set 2 10/08/20, 14:24
FileDumpController.php:155ReplyWouldn't this just complicate things for the user? The user would then need to make sure to create a token for all query params but "dl" in the url. (see example in changelog file) -
TYPO3com voted on patch set 2 V -1 10/08/20, 14:30 Completed build in 15m 36s on Thu, 8 Oct, 02:30 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6369
-
TYPO3com voted on patch set 1 V -1 10/08/20, 14:30 Completed build in 18m 20s on Thu, 8 Oct, 02:30 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6368
-
Christian Eßl uploaded patch set 3 10/08/20, 14:38
-
Christian Eßl updated the commit message in patch set 4 10/08/20, 14:39
-
Markus Klein commented on patch set 4 10/08/20, 14:55
FileDumpController.php:155ReplyIMO the user(dev) usually doesn't do this on its own. getPublicUrl() of FAL is responsible for this. I see that as the main usecase. -
TYPO3com voted on patch set 3 V +1 10/08/20, 14:56 Completed build in 17m 55s on Thu, 8 Oct, 02:56 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6370
-
TYPO3com voted on patch set 4 V +1 10/08/20, 15:02 Completed build in 20m 54s on Thu, 8 Oct, 03:02 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6371
-
Oli Bartsch uploaded patch set 5 05/18/21, 12:10
-
Oli Bartsch commented on patch set 5 05/18/21, 12:19
FileDumpController.php:155Reply UnresolvedCurrent approach is IMO right. All those parameters have to be included in the token generation. Having a token, generated from parameters, which however does not necessarily include all query parameters, is IMO self-defeating. In case people are using getPublicUrl() and want to add additional parameters to the result, they simply have to recalculate the token manually afterwards. However, to support devs, I think it would be helpful to have a ViewHelper at hand, dealing with the internal stuff, like calculating the token. -
core-ci voted on patch set 5 V +1 05/18/21, 12:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11618
-
Oli Bartsch uploaded patch set 6 05/18/21, 20:33
-
core-ci voted on patch set 6 V +1 05/18/21, 20:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11638
-
Oli Bartsch uploaded patch set 7 05/18/21, 20:45
-
core-ci voted on patch set 7 V -1 05/18/21, 20:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11641
-
Oli Bartsch uploaded patch set 8 05/18/21, 20:54
-
core-ci voted on patch set 8 V -1 05/18/21, 20:55 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11643
-
Oli Bartsch uploaded patch set 9 05/18/21, 22:31
-
core-ci voted on patch set 9 V -1 05/18/21, 22:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11653
-
Oli Bartsch uploaded patch set 10 05/18/21, 22:49
-
core-ci voted on patch set 10 V +1 05/18/21, 22:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11654
-
Jochen Roth commented on patch set 10 05/19/21, 11:33
Just nitpicking ;-)Feature-92518-DownloadAndFilenameOptionsAddedToFileDumpController.rst:44Should be "file". Maybe change 'file="123"' to 'file="{file}"' coz this could be misleading that this also takes a file UID which did not work for me.FileViewHelper.php:55Should be "file". Maybe change 'file="123"' to 'file="{file}"' coz this could be misleading that this also takes a file UID which did not work for me. -
Jochen Roth uploaded patch set 11 05/19/21, 11:48
-
Jochen Roth commented on patch set 11 V +1 CR +1 05/19/21, 11:53
Feature-92518-DownloadAndFilenameOptionsAddedToFileDumpController.rst:44ReplyDoneFileViewHelper.php:55ReplyDone -
core-ci voted on patch set 11 V +1 05/19/21, 11:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11671
-
André Buchmann commented on patch set 11 05/19/21, 12:11
FileViewHelper.php:55</f:link.page> should be </f:link.file> -
Jochen Roth uploaded patch set 12 05/19/21, 12:16
-
André Buchmann commented on patch set 12 CR +1 05/19/21, 12:24
FileViewHelper.php:55ReplyDone -
core-ci voted on patch set 12 V +1 05/19/21, 12:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11675
-
Jochen Roth uploaded patch set 13 05/19/21, 14:23
-
core-ci voted on patch set 13 V +1 05/19/21, 14:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11677
-
Oli Bartsch uploaded patch set 14 05/19/21, 14:50
-
Jochen Roth voted on patch set 14 V +1 CR +1 05/19/21, 14:52
-
core-ci voted on patch set 14 V +1 05/19/21, 15:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11680
-
André Buchmann voted on patch set 14 CR +1 05/19/21, 15:18
-
Oli Bartsch commented on patch set 14 CR -1 05/19/21, 20:47
Will add some tests for the new ViewHelper. -
Oli Bartsch uploaded patch set 15 05/21/21, 14:58
-
core-ci voted on patch set 15 V +1 05/21/21, 15:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11781
-
Oli Bartsch uploaded patch set 16 05/21/21, 15:31
-
core-ci voted on patch set 16 V +1 05/21/21, 15:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11783
-
Benni Mack voted on patch set 16 CR +1 05/25/21, 10:17
-
Jochen Roth voted on patch set 16 V +1 CR +1 05/25/21, 10:53
-
Richard Haeser voted on patch set 16 CR +1 05/26/21, 11:50
-
Benni Mack voted on patch set 16 V +2 CR +2 05/26/21, 20:25
-
Benni Mack merged patch set 17 05/26/21, 20:25
Unresolved