66087[BUGFIX] Fix SQL error in backend user list on PostgreSQL
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Markus Klein +1
- Mathias Brodala +1
-
Verified V +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Stephan Großberndt uploaded patch set 1 10/08/20, 15:43
-
Stephan Großberndt wrote 10/08/20, 15:44
Topic set to postgresql -
Mathias Brodala commented on patch set 1 V +1 CR +1 10/08/20, 15:52
This should also speed up lookup by UID on all DBMS. -
TYPO3com voted on patch set 1 V -1 10/08/20, 16:00 Completed build in 16m 04s on Thu, 8 Oct, 04:00 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6374
-
Oli Bartsch commented on patch set 1 10/08/20, 16:54
BackendUserRepository.php:64Now we have getUserName() called four times. Would suggest creating a local variabel inside the if body. -
TYPO3com voted on patch set 1 V +1 10/08/20, 16:58 Completed build in 1h 30m 09s on Thu, 8 Oct, 04:58 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6374
-
Oliver Klee voted on patch set 1 CR +1 10/08/20, 21:09
-
Markus Klein voted on patch set 1 V +1 CR +1 10/13/20, 11:51
-
Christian Kuhn commented on patch set 1 V +2 CR +2 10/13/20, 12:06
BackendUserRepository.php:64Reply UnresolvedFrankly, I don't care too much: This getter basically costs no time and compiler may optimize that away anyway. I'd rather keep given votes and merge as is. -
Christian Kuhn merged patch set 2 10/13/20, 12:06
-
Christian Kuhn commented on patch set 2 10/13/20, 12:07
since that's a crash that is relatively easy to solve, i'm ok with v9 for this one.