Review main Merged

66089[FEATURE] Show table and field names in ext:lowlevel

Christian Eßl CR +2 V +2 Easy +45 −1 updated 10/09/20, 07:32

Commit message

If the configuration `['BE']['debug']` is enabled and the current user is an
administrator, the name of a DB table or DB field is appended to the select
options in the "Full Search" module of ext:lowlevel.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Christian Eßl uploaded patch set 1 10/08/20, 16:27

  2. Josef Glatz voted on patch set 1 V +1 CR +1 10/08/20, 16:37

  3. TYPO3com voted on patch set 1 V +1 10/08/20, 16:39 Completed build in 12m 03s on Thu, 8 Oct, 04:39 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6375

  4. Daniel Goerz commented on patch set 1 CR -1 10/08/20, 16:56

    QueryGenerator.php:2184 Unresolved

    Can we move this condition outside the loops, so its only checked once?
  5. Daniel Goerz uploaded patch set 2 10/08/20, 17:05

  6. Josef Glatz voted on patch set 2 CR +1 10/08/20, 17:08

  7. Daniel Goerz uploaded patch set 3 10/08/20, 17:09

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 10/08/20, 17:09

  9. Josef Glatz voted on patch set 3 V +1 CR +1 10/08/20, 17:09

  10. TYPO3com voted on patch set 2 V -1 10/08/20, 17:19 Completed build in 14m 13s on Thu, 8 Oct, 05:19 PM Test Summary: 1 of 74249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6377

  11. TYPO3com voted on patch set 3 V +1 10/08/20, 17:23 Completed build in 14m 51s on Thu, 8 Oct, 05:23 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6378

  12. Alexander Schnitzler voted on patch set 3 V +1 CR +1 10/09/20, 07:21

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 10/09/20, 07:32

  14. Daniel Goerz merged patch set 4 10/09/20, 07:32