Review main Merged

66090[BUGFIX] Show translated reference in shortcut preview of page module

Christian Eßl CR +2 V +2 Easy +23 −0 updated 11/15/21, 17:33

Commit message

Previously, when creating a translated content element of
type `shortcut`, the preview in the page module would
always show the title of the reference from the original
language. In case the referenced record has been translated
as well, the preview now shows the translated title instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Christian Eßl uploaded patch set 1 10/08/20, 17:28

  2. TYPO3com voted on patch set 1 V +1 10/08/20, 17:42 Completed build in 13m 48s on Thu, 8 Oct, 05:42 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6380

  3. Benni Mack rebased onto patch set 2 11/03/21, 17:49

  4. core-ci voted on patch set 2 V +1 11/03/21, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18808

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/03/21, 21:17

  6. Benni Mack commented on patch set 2 CR -1 11/11/21, 11:02

    StandardContentPreviewRenderer.php:139

    "sys_language_uid" is hardcoded here, but could be different depending on $tableName, needs adaption. Also we should check for BackendUtility::isLocalizable() as well
  7. Benni Mack uploaded patch set 3 11/11/21, 14:07

  8. core-ci voted on patch set 3 V +1 11/11/21, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19181

  9. Benni Mack commented on patch set 3 11/11/21, 15:53

    StandardContentPreviewRenderer.php:139 Reply

    Done
  10. Nikita Hovratov uploaded patch set 4 11/15/21, 16:49

  11. Nikita Hovratov commented on patch set 4 V +1 CR +1 11/15/21, 16:52

    PageLayoutView is de facto not available anymore in v11. It is only there for some old hooks. I extracted the translation code into an own method, for less nesting and cleaner scope.
  12. core-ci voted on patch set 4 V +1 11/15/21, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19308

  13. Benni Mack voted on patch set 4 V +2 CR +2 11/15/21, 17:33

  14. Benni Mack merged patch set 5 11/15/21, 17:33