Review main Merged

66091[TASK] Remove empty array from site configuration before persisting

Georg Ringer CR +2 V +2 Easy +7 −0 updated 10/08/20, 20:56

Commit message

Having empty array like `routes: {  }` make it hard to lint the site
configuration yaml files. To have a cleaner state, those empty arrays
are removed before they are persisted.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Markus Klein +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Georg Ringer uploaded patch set 1 10/08/20, 17:33

  2. Georg Ringer commented on patch set 1 10/08/20, 17:34

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 10/08/20, 17:34 Completed build in 26s on Thu, 8 Oct, 05:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6381

  4. Georg Ringer uploaded patch set 2 10/08/20, 17:36

  5. TYPO3com voted on patch set 2 V +1 10/08/20, 17:49 Completed build in 12m 32s on Thu, 8 Oct, 05:49 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6382

  6. Josef Glatz updated the commit message in patch set 3 10/08/20, 17:58

  7. TYPO3com voted on patch set 3 V +1 10/08/20, 18:11 Completed build in 12m 42s on Thu, 8 Oct, 06:11 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6383

  8. Benni Mack voted on patch set 3 V +1 CR +1 10/08/20, 19:07

  9. Josef Glatz voted on patch set 3 CR +1 10/08/20, 19:13

  10. Josef Glatz commented on patch set 3 V +1 10/08/20, 19:14

    looks good in 10.4 for me in an real world project
  11. Markus Klein voted on patch set 3 V +1 CR +1 10/08/20, 19:40

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 10/08/20, 19:41

  13. Georg Ringer voted on patch set 3 V +2 CR +2 10/08/20, 20:56

  14. Georg Ringer merged patch set 4 10/08/20, 20:56