Review main Merged Breaking

66093[!!!][TASK] Remove per-user IP locking for backend users

Benni Mack CR +2 V +2 Normal +71 −124 updated 10/14/20, 13:12

Commit message

The IP-locking functionality is disabled in TYPO3 v10 by default due to
IPv4/IPv6 hopping ("Happy eyeballs"), however the per-Backend-User
option is now removed, as it effectively needs custom enablement.

IF IP locking is needed for the backend, this is now configurable
only on a per-installation basis. If needed, it is recommended to
implement this feature, which was disabled by default
(which depends on a feature, which is disabled by default) as
a custom extension.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 1318

  1. Benni Mack uploaded patch set 1 10/09/20, 13:32

  2. TYPO3com voted on patch set 1 V -1 10/09/20, 13:50 Completed build in 11m 01s on Fri, 9 Oct, 01:50 PM Test Summary: 8369 of 74136 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6402

  3. Benni Mack rebased onto patch set 2 10/13/20, 14:45

  4. TYPO3com voted on patch set 2 V +1 10/13/20, 15:10 Completed build in 24m 28s on Tue, 13 Oct, 03:10 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6479

  5. Benni Mack updated the commit message in patch set 3 10/13/20, 19:13

  6. Christian Kuhn commented on patch set 3 10/13/20, 19:24

    Compare.html:212 Unresolved

    missing removal from locallang file
  7. Benni Mack uploaded patch set 4 10/13/20, 19:31

  8. TYPO3com voted on patch set 3 V -1 10/13/20, 19:32 Completed build in 18m 30s on Tue, 13 Oct, 07:32 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6502

  9. TYPO3com voted on patch set 4 V +1 10/13/20, 19:43 Completed build in 12m 10s on Tue, 13 Oct, 07:43 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6503

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 10/13/20, 20:14

  11. Simon Gilli commented on patch set 4 CR +1 10/14/20, 10:22

    Change looks fine, had no time to test it properly so far...
  12. Oli Bartsch uploaded patch set 5 10/14/20, 10:49

  13. Oli Bartsch voted on patch set 5 V +1 CR +1 10/14/20, 10:50

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 10/14/20, 10:55

  15. Simon Gilli voted on patch set 5 CR +1 10/14/20, 12:47

  16. TYPO3com voted on patch set 5 V +1 10/14/20, 13:01 Completed build in 18m 02s on Wed, 14 Oct, 01:01 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6536

  17. Benni Mack voted on patch set 5 V +2 CR +2 10/14/20, 13:12

  18. Benni Mack merged patch set 6 10/14/20, 13:12