Review main Merged

66094[TASK] Use SVG icon sprites

Andreas Kienast CR +2 V +2 Nightmare +4430 −586 updated 11/04/20, 18:46

Commit message

This patch updates @typo3/icons to version 2.x delivering icon sprites.
Using icon sprites greatly improves backend performance for several
reasons:

- A single sprite file contains multiple icons which need to be loaded
  once only
- The DOM is reduced as it's not necessary to load SVG icons inline
  anymore to apply styling

Todo for a later patch:

- Replace aliases with "real" icon identifiers

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1014

Show 994 more files

Review log 2131

Show 46 earlier messages
  1. Andreas Kienast uploaded patch set 1 10/09/20, 14:01

  2. TYPO3com voted on patch set 1 V -1 10/09/20, 14:01 Completed build in 24s on Fri, 9 Oct, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6403

  3. Andreas Kienast voted on patch set 1 CR -2 10/09/20, 14:02

  4. Andreas Kienast uploaded patch set 2 10/09/20, 14:11

  5. TYPO3com voted on patch set 2 V -1 10/09/20, 14:24 Completed build in 12m 37s on Fri, 9 Oct, 02:24 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6404

  6. Andreas Kienast uploaded patch set 3 10/23/20, 08:31

  1. TYPO3com voted on patch set 3 V +1 10/23/20, 08:45 Completed build in 13m 48s on Fri, 23 Oct, 08:45 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6822

  2. Andreas Kienast uploaded patch set 4 10/23/20, 09:58

  3. TYPO3com voted on patch set 4 V -1 10/23/20, 10:10 Completed build in 11m 29s on Fri, 23 Oct, 10:10 AM Test Summary: 13 of 73967 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6825

  4. Andreas Kienast uploaded patch set 5 10/23/20, 10:14

  5. TYPO3com voted on patch set 5 V -1 10/23/20, 10:28 Completed build in 13m 15s on Fri, 23 Oct, 10:28 AM Test Summary: 1 of 73967 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6826

  6. Andreas Kienast uploaded patch set 6 10/23/20, 11:01

  7. TYPO3com voted on patch set 6 V +1 10/23/20, 11:15 Completed build in 13m 50s on Fri, 23 Oct, 11:15 AM Test Summary: 73482 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6835

  8. Andreas Kienast updated the commit message in patch set 7 10/23/20, 12:52

  9. Andreas Kienast voted on patch set 7 CR 0 10/23/20, 13:03

  10. TYPO3com voted on patch set 7 V +1 10/23/20, 13:06 Completed build in 14m 38s on Fri, 23 Oct, 01:06 PM Test Summary: 73482 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6843

  11. Andreas Kienast uploaded patch set 8 10/30/20, 09:02

  12. TYPO3com voted on patch set 8 V +1 10/30/20, 09:14 Completed build in 11m 40s on Fri, 30 Oct, 09:14 AM Test Summary: 73578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7027

  13. Markus Klein commented on patch set 8 10/30/20, 10:05

    SvgSpriteIconProvider.php:26

    is the description still correct?

    IconRegistry.php:493

    can't we move this information into the json file now, we we get rid of the "hotfix"?
  14. Andreas Kienast commented on patch set 8 10/30/20, 10:21

    SvgSpriteIconProvider.php:26 Reply Unresolved

    Nope. I fixed that once but obviously forgot to push m(

    IconRegistry.php:493 Reply Unresolved

    Not right now. I'll talk with Benji about how we may handle this in the future.
  15. Andreas Kienast uploaded patch set 9 10/30/20, 10:29

  16. Markus Klein voted on patch set 9 CR +1 10/30/20, 10:31

  17. TYPO3com voted on patch set 9 V +1 10/30/20, 10:47 Completed build in 16m 45s on Fri, 30 Oct, 10:47 AM Test Summary: 73578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7030

  18. Andreas Kienast commented on patch set 9 V -1 10/30/20, 12:31

    It seems the CSS needs some love. In EditDocumentController, the labels in the buttons (e.g. "Save") moved down a bit.
  19. Andreas Kienast uploaded patch set 10 10/30/20, 13:32

  20. TYPO3com voted on patch set 10 V +1 10/30/20, 13:44 Completed build in 11m 33s on Fri, 30 Oct, 01:44 PM Test Summary: 73581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7033

  21. Markus Klein commented on patch set 10 V +1 CR +1 10/30/20, 23:24

    looks good
  22. Anja Leichsenring voted on patch set 10 V +1 CR +1 11/01/20, 08:04

  23. Georg Ringer voted on patch set 10 CR +1 11/01/20, 18:22

  24. Anja Leichsenring voted on patch set 10 V +2 CR +2 11/04/20, 18:45

  25. Anja Leichsenring merged patch set 11 11/04/20, 18:46