66095[!!!][TASK] Remove fluid widgets
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 41
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92529-AllFluidWidgetFunctionalityRemoved.rstnew+65 −0
- typo3/sysext/core/Tests/Unit/Utility/ClassNamingUtilityTest.php+0 −10
- typo3/sysext/extbase/Tests/Functional/Configuration/RequestHandlerConfigurationFactoryTest.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+0 −10
- typo3/sysext/fluid/Classes/Core/Widget/Exception/MissingControllerException.phpdeleted+0 −27
- typo3/sysext/fluid/Classes/Core/Widget/Exception/RenderingContextNotFoundException.phpdeleted+0 −27
- typo3/sysext/fluid/Classes/Core/Widget/Exception/WidgetContextNotFoundException.phpdeleted+0 −27
- typo3/sysext/fluid/Classes/Core/Widget/Exception/WidgetRequestNotFoundException.phpdeleted+0 −27
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetController.phpdeleted+0 −81
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.phpdeleted+0 −285
- typo3/sysext/fluid/Classes/Core/Widget/AjaxWidgetContextHolder.phpdeleted+0 −137
- typo3/sysext/fluid/Classes/Core/Widget/Bootstrap.phpdeleted+0 −81
- typo3/sysext/fluid/Classes/Core/Widget/Exception.phpdeleted+0 −23
- typo3/sysext/fluid/Classes/Core/Widget/WidgetContext.phpdeleted+0 −277
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequest.phpdeleted+0 −62
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestBuilder.phpdeleted+0 −79
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestHandler.phpdeleted+0 −111
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/Controller/PaginateController.phpdeleted+0 −131
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/PaginateViewHelper.phpdeleted+0 −87
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/Controller/PaginateController.phpdeleted+0 −212
Show 21 more files
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/LinkViewHelper.phpdeleted+0 −136
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/PaginateViewHelper.phpdeleted+0 −102
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/UriViewHelper.phpdeleted+0 −128
- typo3/sysext/fluid/Classes/ViewHelpers/RenderChildrenViewHelper.phpdeleted+0 −133
- typo3/sysext/fluid/Configuration/Extbase/RequestHandlers.phpdeleted+0 −7
- typo3/sysext/fluid/Resources/Private/Language/locallang.xlfdeleted+0 −32
- typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Be/Widget/Paginate/Index.htmldeleted+0 −103
- typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Paginate/Index.htmldeleted+0 −68
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Configuration/TypoScript/Basic.ts+0 −7
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Configuration/TypoScript/ExtbaseController.ts+0 −8
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Resources/Private/Base/Templates/Template/BaseTemplate.html+1 −3
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+0 −34
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetControllerTest.phpdeleted+0 −197
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetViewHelperTest.phpdeleted+0 −264
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AjaxWidgetContextHolderTest.phpdeleted+0 −43
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetContextTest.phpdeleted+0 −142
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestBuilderTest.phpdeleted+0 −203
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestHandlerTest.phpdeleted+0 −100
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestTest.phpdeleted+0 −70
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Widget/Controller/PaginateControllerTest.phpdeleted+0 −297
- typo3/sysext/fluid/ext_typoscript_setup.typoscriptdeleted+0 −17
Review log 1217
-
Alexander Schnitzler uploaded patch set 1 10/09/20, 14:19
-
Alexander Schnitzler wrote 10/09/20, 14:19
Topic set to fluid -
TYPO3com voted on patch set 1 V -1 10/09/20, 14:31 Completed build in 12m 33s on Fri, 9 Oct, 02:31 PM Test Summary: 59 of 73542 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6405
-
Alexander Schnitzler uploaded patch set 2 10/09/20, 15:06
-
Alexander Schnitzler uploaded patch set 3 10/09/20, 15:15
-
TYPO3com voted on patch set 2 V -1 10/09/20, 15:19 Completed build in 13m 31s on Fri, 9 Oct, 03:19 PM Test Summary: 6 of 73895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6407
-
Markus Klein commented on patch set 3 10/09/20, 15:21
Lovely, will review for sure -
TYPO3com voted on patch set 3 V +1 10/09/20, 15:31 Completed build in 16m 20s on Fri, 9 Oct, 03:31 PM Test Summary: 73404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6411
-
Claus Due commented on patch set 3 CR -1 10/09/20, 15:48
Overall looks *really* good and has been a long time coming. I'm 100% for removing this entire feature set. I only have this small comment about the RST wording - as soon as that's changed I'll +1 and do a quick round of testing. Q: would it be possible to add a deprecation scan for this which we perhaps could push to 10.4? As a separate patch of course!Breaking-92529-FluidWidgetsAreDead.rst:4We should probably pick a less "combative" title, e.g. "All Fluid widget functionality removed". Same for the file name of this RST. -
Alexander Schnitzler commented on patch set 3 10/09/20, 16:48
> Patch Set 3: Code-Review-1 > > (1 comment) > > Overall looks *really* good and has been a long time coming. I'm 100% for removing this entire feature set. > > I only have this small comment about the RST wording - as soon as that's changed I'll +1 and do a quick round of testing. > > Q: would it be possible to add a deprecation scan for this which we perhaps could push to 10.4? As a separate patch of course! I hoped for your input on this. Any idea what should be scanned for exactly? It's quite unfortunate we don't have a clear api here as there is no interface people needed to implement.Breaking-92529-FluidWidgetsAreDead.rst:4Reply UnresolvedI agree. I deliberately chose that title to draw some attention to this rst file. I really need reviewers here more than I do for the code removal part. Something I discussed already with Benni was mentioning the commits that show how the core migrated away from the pagination widget. -
Alexander Schnitzler uploaded patch set 4 10/16/20, 09:13
-
TYPO3com voted on patch set 4 V +1 10/16/20, 09:27 Completed build in 13m 32s on Fri, 16 Oct, 09:27 AM Test Summary: 73362 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6572
-
Christian Kuhn uploaded patch set 5 10/19/20, 22:01
-
TYPO3com voted on patch set 5 V +1 10/19/20, 22:19 Completed build in 14m 53s on Mon, 19 Oct, 10:19 PM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6677
-
Christian Kuhn voted on patch set 5 V +1 CR +1 10/19/20, 22:40
-
Benni Mack voted on patch set 5 V +2 CR +2 10/20/20, 07:43
-
Benni Mack merged patch set 6 10/20/20, 07:43