Review main Merged Breaking

66095[!!!][TASK] Remove fluid widgets

Alexander Schnitzler CR +2 V +2 Nightmare +66 −3790 updated 10/20/20, 07:43

Commit message

All fluid widgets and the core widget functionality has
been removed due to its complexity and the fact that
fluid widgets did and do bring more trouble than benefit.

The most commonly used paginate widget can be replaced with
a recently introduced new core api. Examples of how to use
it can be found in the core itself. Extensions be_user and
extensionmanager did use the pagination widget before and
do now use the core pagination api.

Custom widgets and their functionality have to be
reimplemented in another way. The usual way to replace a
widget is to put its functionality into the controller
action and move the widgets query params into the query
param namespace of the plugin that formerly rendered the
widget.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 41

Show 21 more files

Review log 1217

  1. Alexander Schnitzler uploaded patch set 1 10/09/20, 14:19

  2. Alexander Schnitzler wrote 10/09/20, 14:19

    Topic set to fluid
  3. TYPO3com voted on patch set 1 V -1 10/09/20, 14:31 Completed build in 12m 33s on Fri, 9 Oct, 02:31 PM Test Summary: 59 of 73542 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6405

  4. Alexander Schnitzler uploaded patch set 2 10/09/20, 15:06

  5. Alexander Schnitzler uploaded patch set 3 10/09/20, 15:15

  6. TYPO3com voted on patch set 2 V -1 10/09/20, 15:19 Completed build in 13m 31s on Fri, 9 Oct, 03:19 PM Test Summary: 6 of 73895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6407

  7. Markus Klein commented on patch set 3 10/09/20, 15:21

    Lovely, will review for sure
  8. TYPO3com voted on patch set 3 V +1 10/09/20, 15:31 Completed build in 16m 20s on Fri, 9 Oct, 03:31 PM Test Summary: 73404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6411

  9. Claus Due commented on patch set 3 CR -1 10/09/20, 15:48

    Overall looks *really* good and has been a long time coming. I'm 100% for removing this entire feature set. I only have this small comment about the RST wording - as soon as that's changed I'll +1 and do a quick round of testing. Q: would it be possible to add a deprecation scan for this which we perhaps could push to 10.4? As a separate patch of course!

    Breaking-92529-FluidWidgetsAreDead.rst:4

    We should probably pick a less "combative" title, e.g. "All Fluid widget functionality removed". Same for the file name of this RST.
  10. Alexander Schnitzler commented on patch set 3 10/09/20, 16:48

    > Patch Set 3: Code-Review-1 > > (1 comment) > > Overall looks *really* good and has been a long time coming. I'm 100% for removing this entire feature set. > > I only have this small comment about the RST wording - as soon as that's changed I'll +1 and do a quick round of testing. > > Q: would it be possible to add a deprecation scan for this which we perhaps could push to 10.4? As a separate patch of course! I hoped for your input on this. Any idea what should be scanned for exactly? It's quite unfortunate we don't have a clear api here as there is no interface people needed to implement.

    Breaking-92529-FluidWidgetsAreDead.rst:4 Reply Unresolved

    I agree. I deliberately chose that title to draw some attention to this rst file. I really need reviewers here more than I do for the code removal part. Something I discussed already with Benni was mentioning the commits that show how the core migrated away from the pagination widget.
  11. Alexander Schnitzler uploaded patch set 4 10/16/20, 09:13

  12. TYPO3com voted on patch set 4 V +1 10/16/20, 09:27 Completed build in 13m 32s on Fri, 16 Oct, 09:27 AM Test Summary: 73362 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6572

  13. Christian Kuhn uploaded patch set 5 10/19/20, 22:01

  14. TYPO3com voted on patch set 5 V +1 10/19/20, 22:19 Completed build in 14m 53s on Mon, 19 Oct, 10:19 PM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6677

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 10/19/20, 22:40

  16. Benni Mack voted on patch set 5 V +2 CR +2 10/20/20, 07:43

  17. Benni Mack merged patch set 6 10/20/20, 07:43