Review main Merged Breaking

66097[!!!][TASK] EM: Drop support for extensions-in-extensions installation

Benni Mack CR +2 V +2 Normal +58 −190 updated 10/12/20, 08:04

Commit message

A feature which was built for the introduction package back then, which
allowed to ship a modified / custom extension as dependency, where
one could put another extension in EXT:my_ext/Initialisation/Extensions/another_ext
is removed, as this special case is

a) not needed anymore
b) not following any rules of being conformant for "dependency hell"
c) specific for dependency handling of TYPO3 (non-composer)

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1320

  1. Benni Mack uploaded patch set 1 10/09/20, 19:45

  2. TYPO3com voted on patch set 1 V +1 10/09/20, 19:57 Completed build in 11m 41s on Fri, 9 Oct, 07:57 PM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6422

  3. Alexander Schnitzler commented on patch set 1 10/10/20, 06:12

    Oh wow, that was possible? Holy smokes!
  4. Benni Mack updated the commit message in patch set 2 10/10/20, 18:37

  5. TYPO3com voted on patch set 2 V +1 10/10/20, 18:49 Completed build in 12m 43s on Sat, 10 Oct, 06:49 PM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6424

  6. Benni Mack uploaded patch set 3 10/10/20, 18:59

  7. Benni Mack uploaded patch set 4 10/10/20, 19:00

  8. TYPO3com voted on patch set 3 V -1 10/10/20, 19:12 Completed build in 13m 02s on Sat, 10 Oct, 07:12 PM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6426

  9. TYPO3com voted on patch set 4 V -1 10/10/20, 19:17 Completed build in 15m 47s on Sat, 10 Oct, 07:17 PM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6427

  10. Benni Mack uploaded patch set 5 10/10/20, 19:21

  11. Oli Bartsch uploaded patch set 6 10/10/20, 19:25

  12. TYPO3com voted on patch set 5 V +1 10/10/20, 19:34 Completed build in 12m 55s on Sat, 10 Oct, 07:34 PM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6430

  13. TYPO3com voted on patch set 6 V -1 10/10/20, 19:39 Completed build in 14m 34s on Sat, 10 Oct, 07:39 PM Test Summary: 12 of 74213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6431

  14. Oli Bartsch uploaded patch set 7 10/10/20, 19:49

  15. TYPO3com voted on patch set 7 V +1 10/10/20, 20:03 Completed build in 14m 02s on Sat, 10 Oct, 08:03 PM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6432

  16. Oli Bartsch voted on patch set 7 V +1 CR +1 10/10/20, 20:17

  17. Daniel Goerz voted on patch set 7 V +2 CR +2 10/12/20, 07:54

  18. Daniel Goerz merged patch set 8 10/12/20, 07:54

  19. Andreas Kienast commented on patch set 8 10/12/20, 07:58

    Breaking-92532-SupportForExtension-in-extensionInstallationInExtensionManagerRemoved.rst:4 Unresolved

    nope
  20. Daniel Goerz commented on patch set 8 10/12/20, 08:04