Review main Merged

66100[TASK] Decouple Dependency logic and domain models in EM

Benni Mack CR +2 V +2 Expert +635 −833 updated 10/12/20, 16:38

Commit message

Both Domain\Model\Extension and Domain\Model\Dependency now have
factory methods to avoid using the ExtensionModelUtility to build
objects in an atomic state.

This marks the ExtensionModelUtility class obsolete, which resolved
dependencies and built Dependency objects.

The Dependency object is now not an AbstractEntity anymore, but more
of a type ValueObject.

However, since the Dependency object knows about the min/max version
constraints, this logic is now shifted into this class, making the
DependencyUtility much smaller in logic.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 1627

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 10/12/20, 07:40

  2. TYPO3com voted on patch set 1 V -1 10/12/20, 07:53 Completed build in 12m 59s on Mon, 12 Oct, 07:53 AM Test Summary: 199 of 74219 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6434

  1. Benni Mack uploaded patch set 2 10/12/20, 10:58

  2. TYPO3com voted on patch set 2 V -1 10/12/20, 10:58 Completed build in 23s on Mon, 12 Oct, 10:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6440

  3. Benni Mack uploaded patch set 3 10/12/20, 11:09

  4. TYPO3com voted on patch set 3 V -1 10/12/20, 11:20 Completed build in 10m 56s on Mon, 12 Oct, 11:20 AM Test Summary: 12 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6441

  5. Oli Bartsch uploaded patch set 4 10/12/20, 12:19

  6. TYPO3com voted on patch set 4 V +1 10/12/20, 12:33 Completed build in 13m 29s on Mon, 12 Oct, 12:33 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6442

  7. Oli Bartsch uploaded patch set 5 10/12/20, 13:00

  8. Benni Mack updated the commit message in patch set 6 10/12/20, 13:07

  9. TYPO3com voted on patch set 5 V +1 10/12/20, 13:13 Completed build in 12m 24s on Mon, 12 Oct, 01:13 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6443

  10. TYPO3com voted on patch set 6 V +1 10/12/20, 13:20 Completed build in 12m 52s on Mon, 12 Oct, 01:20 PM Test Summary: 73720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6444

  11. Benni Mack uploaded patch set 7 10/12/20, 13:20

  12. TYPO3com voted on patch set 7 V +1 10/12/20, 13:33 Completed build in 13m 12s on Mon, 12 Oct, 01:33 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6445

  13. Daniel Goerz commented on patch set 7 10/12/20, 15:15

    ExtensionRepository.php:284

    maybe pass $query->execute()->toArray() to always have array, or change annotations and type hints to QueryResultInterface. Same above.

    ExtensionRepository.php:343

    filterYoungestVersionOfExtensionList() has $extensions declared as Extension[]

    ExtensionRepository.php:362

    Method above says Get (instead of Gets)

    ExtensionRepository.php:370

    type of $extensions missing
  14. Oli Bartsch uploaded patch set 8 10/12/20, 15:19

  15. Oli Bartsch uploaded patch set 9 10/12/20, 15:27

  16. Markus Klein updated the commit message in patch set 10 10/12/20, 15:27

  17. TYPO3com voted on patch set 8 V +1 10/12/20, 15:32 Completed build in 12m 42s on Mon, 12 Oct, 03:32 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6448

  18. Oli Bartsch commented on patch set 10 10/12/20, 15:32

    ExtensionRepository.php:284 Reply

    Done

    ExtensionRepository.php:343 Reply

    Done

    ExtensionRepository.php:362 Reply

    Done

    ExtensionRepository.php:370 Reply

    Done
  19. TYPO3com voted on patch set 9 V +1 10/12/20, 15:40 Completed build in 12m 46s on Mon, 12 Oct, 03:40 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6449

  20. TYPO3com voted on patch set 10 V +1 10/12/20, 15:44 Completed build in 17m 11s on Mon, 12 Oct, 03:44 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6450

  21. Markus Klein updated the commit message in patch set 11 10/12/20, 15:47

  22. Oli Bartsch voted on patch set 11 V +1 CR +1 10/12/20, 15:52

  23. TYPO3com voted on patch set 11 V +1 10/12/20, 15:58 Completed build in 11m 29s on Mon, 12 Oct, 03:58 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6451

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 10/12/20, 16:37

  25. Christian Kuhn merged patch set 12 10/12/20, 16:38