66100[TASK] Decouple Dependency logic and domain models in EM
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+2 −15
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+4 −8
- typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php+73 −46
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+64 −3
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php8+57 −6
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+1 −15
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+47 −159
- typo3/sysext/extensionmanager/Classes/Utility/ExtensionModelUtility.phpdeleted+0 −89
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+17 −67
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+45 −17
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+17 −38
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/DependencyTest.phpnew+45 −0
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/ExtensionTest.php+118 −0
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Repository/ExtensionRepositoryTest.phpnew+110 −0
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+8 −8
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+27 −206
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ExtensionModelUtilityTest.phpdeleted+0 −147
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+0 −9
Review log 1627
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 10/12/20, 07:40
-
TYPO3com voted on patch set 1 V -1 10/12/20, 07:53 Completed build in 12m 59s on Mon, 12 Oct, 07:53 AM Test Summary: 199 of 74219 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6434
-
Benni Mack uploaded patch set 2 10/12/20, 10:58
-
TYPO3com voted on patch set 2 V -1 10/12/20, 10:58 Completed build in 23s on Mon, 12 Oct, 10:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6440
-
Benni Mack uploaded patch set 3 10/12/20, 11:09
-
TYPO3com voted on patch set 3 V -1 10/12/20, 11:20 Completed build in 10m 56s on Mon, 12 Oct, 11:20 AM Test Summary: 12 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6441
-
Oli Bartsch uploaded patch set 4 10/12/20, 12:19
-
TYPO3com voted on patch set 4 V +1 10/12/20, 12:33 Completed build in 13m 29s on Mon, 12 Oct, 12:33 PM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6442
-
Oli Bartsch uploaded patch set 5 10/12/20, 13:00
-
Benni Mack updated the commit message in patch set 6 10/12/20, 13:07
-
TYPO3com voted on patch set 5 V +1 10/12/20, 13:13 Completed build in 12m 24s on Mon, 12 Oct, 01:13 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6443
-
TYPO3com voted on patch set 6 V +1 10/12/20, 13:20 Completed build in 12m 52s on Mon, 12 Oct, 01:20 PM Test Summary: 73720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6444
-
Benni Mack uploaded patch set 7 10/12/20, 13:20
-
TYPO3com voted on patch set 7 V +1 10/12/20, 13:33 Completed build in 13m 12s on Mon, 12 Oct, 01:33 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6445
-
Daniel Goerz commented on patch set 7 10/12/20, 15:15
ExtensionRepository.php:343filterYoungestVersionOfExtensionList() has $extensions declared as Extension[]ExtensionRepository.php:362Method above says Get (instead of Gets)ExtensionRepository.php:370type of $extensions missing -
Oli Bartsch uploaded patch set 8 10/12/20, 15:19
-
Oli Bartsch uploaded patch set 9 10/12/20, 15:27
-
Markus Klein updated the commit message in patch set 10 10/12/20, 15:27
-
TYPO3com voted on patch set 8 V +1 10/12/20, 15:32 Completed build in 12m 42s on Mon, 12 Oct, 03:32 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6448
-
Oli Bartsch commented on patch set 10 10/12/20, 15:32
ExtensionRepository.php:284ReplyDoneExtensionRepository.php:343ReplyDoneExtensionRepository.php:362ReplyDoneExtensionRepository.php:370ReplyDone -
TYPO3com voted on patch set 9 V +1 10/12/20, 15:40 Completed build in 12m 46s on Mon, 12 Oct, 03:40 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6449
-
TYPO3com voted on patch set 10 V +1 10/12/20, 15:44 Completed build in 17m 11s on Mon, 12 Oct, 03:44 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6450
-
Markus Klein updated the commit message in patch set 11 10/12/20, 15:47
-
Oli Bartsch voted on patch set 11 V +1 CR +1 10/12/20, 15:52
-
TYPO3com voted on patch set 11 V +1 10/12/20, 15:58 Completed build in 11m 29s on Mon, 12 Oct, 03:58 PM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6451
-
Christian Kuhn voted on patch set 11 V +2 CR +2 10/12/20, 16:37
-
Christian Kuhn merged patch set 12 10/12/20, 16:38
ExtensionRepository.php:284