66102[FEATURE] Show extension constraints in extension manager
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Feature-92538-ShowExtensionConstraintsInExtensionManager.rst4new+37 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConstraintsViewHelper.php4new+87 −0
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/ShowAllVersions.html+14 −0
Review log 2436
Show 711 earlier messages
-
Oli Bartsch uploaded patch set 1 10/12/20, 08:59
-
TYPO3com voted on patch set 1 V +1 10/12/20, 09:12 Completed build in 12m 49s on Mon, 12 Oct, 09:12 AM Test Summary: 73726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6438
-
Benni Mack commented on patch set 1 10/12/20, 09:24
-
Oli Bartsch uploaded patch set 2 10/12/20, 09:29
-
Oli Bartsch commented on patch set 2 10/12/20, 09:30
ConstraintsViewHelper.php:57ReplyYep, thanks for the hint. -
Oli Bartsch commented on patch set 2 V -1 10/12/20, 09:35
-
TYPO3com voted on patch set 2 V +1 10/12/20, 09:42 Completed build in 13m 20s on Mon, 12 Oct, 09:42 AM Test Summary: 73728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6439
-
Oli Bartsch uploaded patch set 3 10/12/20, 17:06
-
TYPO3com voted on patch set 3 V +1 10/12/20, 17:19 Completed build in 11m 57s on Mon, 12 Oct, 05:19 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6453
-
Oli Bartsch uploaded patch set 4 10/12/20, 17:33
-
TYPO3com voted on patch set 4 V +1 10/12/20, 17:44 Completed build in 11m 04s on Mon, 12 Oct, 05:44 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6454
-
Oli Bartsch uploaded patch set 5 10/12/20, 17:45
-
Oli Bartsch uploaded patch set 6 10/12/20, 17:50
-
TYPO3com voted on patch set 5 V +1 10/12/20, 17:57 Completed build in 12m 37s on Mon, 12 Oct, 05:57 PM Test Summary: 73712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6455
-
TYPO3com voted on patch set 6 V -1 10/12/20, 18:03 Completed build in 12m 51s on Mon, 12 Oct, 06:03 PM Test Summary: 73706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6456
-
TYPO3com voted on patch set 6 V +1 10/12/20, 18:32 Completed build in 12m 10s on Mon, 12 Oct, 06:32 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6457
-
Oli Bartsch uploaded patch set 7 10/12/20, 18:37
-
TYPO3com voted on patch set 7 V +1 10/12/20, 18:48 Completed build in 11m 24s on Mon, 12 Oct, 06:48 PM Test Summary: 73715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6458
-
Christian Kuhn voted on patch set 7 V +1 CR +1 10/13/20, 13:46
-
Wouter Wolters voted on patch set 7 CR +1 10/13/20, 17:32
-
Anja Leichsenring uploaded patch set 8 10/13/20, 17:42
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 10/13/20, 17:43
-
Wouter Wolters commented on patch set 8 10/13/20, 17:46
Feature-92538-ShowExtensionConstraintsInExtensionManager.rst:19maybe it is my English but I think it should read extension name instead of extensions nameFeature-92538-ShowExtensionConstraintsInExtensionManager.rst:21The last part of this sentence doesn't seem right to me. What do you want to say here? -
Markus Klein commented on patch set 9 10/13/20, 17:47
Published edit on patch set 8. -
Markus Klein commented on patch set 9 10/13/20, 17:49
ConstraintsViewHelper.php:45I would prefer having $arguments['extension'] in a local variable with a type hint -
TYPO3com voted on patch set 8 V -1 10/13/20, 18:09 Completed build in 24m 57s on Tue, 13 Oct, 06:08 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6494
-
TYPO3com voted on patch set 9 V -1 10/13/20, 18:09 Completed build in 19m 19s on Tue, 13 Oct, 06:09 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6495
-
TYPO3com voted on patch set 9 V +1 10/13/20, 18:19 Completed build in 48m 26s on Tue, 13 Oct, 06:19 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6495
-
Oli Bartsch uploaded patch set 10 10/13/20, 18:25
-
Oli Bartsch commented on patch set 10 10/13/20, 18:34
Feature-92538-ShowExtensionConstraintsInExtensionManager.rst:19ReplyDoneFeature-92538-ShowExtensionConstraintsInExtensionManager.rst:21ReplyDoneConstraintsViewHelper.php:45Reply UnresolvedGenerally inline type hints are a good idea for making the IDE aware of the actual type. In this case however we never access any property of the Extension (unless the getDependencies() call in the foreach). The VH is quite straightforward and one can see the type in the registerArgument() call directly. Therefore I don't see the need for declaring a single use variable here. -
TYPO3com voted on patch set 10 V +1 10/13/20, 18:38 Completed build in 13m 45s on Tue, 13 Oct, 06:38 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6497
-
Christian Kuhn voted on patch set 10 V +1 CR +1 10/13/20, 18:39
-
Anja Leichsenring voted on patch set 10 V +1 CR +1 10/13/20, 18:41
-
Wouter Wolters commented on patch set 10 CR +1 10/13/20, 18:46
Looks good to me :) -
Christian Kuhn voted on patch set 10 V +2 CR +2 10/13/20, 18:56
-
Christian Kuhn merged patch set 11 10/13/20, 18:56
ConstraintsViewHelper.php:57