Review main Merged

66110[BUGFIX] Quote double quotes in CSV integrity fix script

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 10/13/20, 15:49

Commit message

Build/Scripts/checkIntegrityCsvFixtures.php --fix destroys
field content that contain double quotes. Quote them properly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 10/13/20, 14:59

  2. Oliver Klee updated the commit message in patch set 2 10/13/20, 15:04

  3. Benni Mack voted on patch set 2 V +1 CR +1 10/13/20, 15:04

  4. Benni Mack commented on patch set 2 10/13/20, 15:05

    I ran into this so many times already, thanks for the fix.
  5. TYPO3com voted on patch set 1 V +1 10/13/20, 15:16 Completed build in 17m 15s on Tue, 13 Oct, 03:16 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6481

  6. TYPO3com voted on patch set 2 V +1 10/13/20, 15:18 Completed build in 13m 54s on Tue, 13 Oct, 03:18 PM Test Summary: 73715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6482

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 10/13/20, 15:48

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/13/20, 15:49

  9. Christian Kuhn merged patch set 3 10/13/20, 15:49