Review 10.4 Merged

66113[BUGFIX] Ensure UserAspect->isLoggedIn() checks for user only

Daniel Goerz CR +2 V +2 Easy +13 −11 updated 10/12/20, 07:48

Commit message

isLoggedIn() is referring to the user, as Frontend sometimes needs
"isUserOrGroupSet()" functionality for working with Admin Panel Previews
or the infamous pages.fe_login_mode where the user log in is hidden but
the group is still valid.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Simon Schaufelberger +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Daniel Goerz commented on patch set 1 10/10/20, 14:01

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php
  2. TYPO3com voted on patch set 1 V -1 10/10/20, 14:01 Completed build in 23s on Sat, 10 Oct, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-609

  3. Daniel Goerz uploaded patch set 2 10/10/20, 14:03

  4. Daniel Goerz commented on patch set 2 10/10/20, 14:04

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 10/10/20, 14:16 Completed build in 12m 47s on Sat, 10 Oct, 02:16 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-610

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 10/12/20, 00:00

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 10/12/20, 07:48

  8. Daniel Goerz merged patch set 3 10/12/20, 07:48