Review 9.5 Merged

66114[BUGFIX] Fix type error in log upgrade wizard

Daniel Goerz CR +2 V +2 Easy +10 −8 updated 10/12/20, 15:18

Commit message

During the update, the value of the field log_data is
unserialized. The expected value is an array, but it was
never validated. If the field contains an invalid value,
unserialize() returns a boolean false.

Now the result is type casted to an array to ensure the
correct type.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Daniel Goerz commented on patch set 1 10/12/20, 10:56

    Cherry Picked from branch 10.4.
  2. TYPO3com voted on patch set 1 V +1 10/12/20, 11:09 Completed build in 13m 26s on Mon, 12 Oct, 11:09 AM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-831

  3. Oliver Klee voted on patch set 1 CR +1 10/12/20, 12:21

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 10/12/20, 15:18

  5. Daniel Goerz merged patch set 2 10/12/20, 15:18