Review 10.4 Merged

66120[BUGFIX] Quote double quotes in CSV integrity fix script

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 10/13/20, 16:36

Commit message

Build/Scripts/checkIntegrityCsvFixtures.php --fix destroys
field content that contain double quotes. Quote them properly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Christian Kuhn commented on patch set 1 10/13/20, 15:49

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 10/13/20, 16:08 Completed build in 18m 34s on Tue, 13 Oct, 04:08 PM Test Summary: 1 of 75309 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-623

  3. TYPO3com voted on patch set 1 V +1 10/13/20, 16:33 Completed build in 1h 02m 11s on Tue, 13 Oct, 04:33 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-623

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/20, 16:36

  5. Christian Kuhn merged patch set 2 10/13/20, 16:36