Review 10.4 Merged

66126[BUGFIX] Return alternative group uids when aspect has no user

Daniel Goerz CR +2 V +2 Easy +20 −8 updated 10/17/20, 08:51

Commit message

When a UserAspect is constructed without any associated
AbstractUserAuthentication user (first constructor argument is null)
as created during Application bootstrap within
\TYPO3\CMS\Frontend\Http\Application::initializeContext(), the
alternative list of group uids needs to be made accessible. This
implies that method getGroupIds() should only check for a
BackendUserAuthentication for a special handling and not do the
erroneous check that it could alternatively be a
FrontendUserAuthentication.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Daniel Goerz commented on patch set 1 10/16/20, 15:26

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/16/20, 15:41 Completed build in 14m 20s on Fri, 16 Oct, 03:41 PM Test Summary: 74847 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-633

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 10/17/20, 08:51

  4. Daniel Goerz merged patch set 2 10/17/20, 08:51