Review 10.4 Merged

66128[BUGFIX] Allow empty string in redirects:integritycheck task

Daniel Goerz CR +2 V +2 Easy +5 −3 updated 10/18/20, 12:04

Commit message

Saving the integritycheck scheduler task a second time without
providing a site identifier will lead to an empty string
being stored.

As the underlying code cant handle an empty string as
identifier, this patch streamlines the input handling and assures
that null is provided instead which means "all sites".

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Daniel Goerz commented on patch set 1 10/18/20, 11:35

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/redirects/Classes/Command/CheckIntegrityCommand.php
  2. TYPO3com voted on patch set 1 V -1 10/18/20, 11:35 Completed build in 24s on Sun, 18 Oct, 11:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-636

  3. Daniel Goerz uploaded patch set 2 10/18/20, 11:39

  4. Daniel Goerz commented on patch set 2 10/18/20, 11:39

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 10/18/20, 11:53 Completed build in 14m 21s on Sun, 18 Oct, 11:53 AM Test Summary: 74847 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-637

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 10/18/20, 12:04

  7. Daniel Goerz merged patch set 3 10/18/20, 12:04