66133[TASK] Use strict type checking in linkvalidator
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 13
- typo3/sysext/linkvalidator/Classes/Configuration/LinkvalidatorConfiguration.php2new+283 −0
- typo3/sysext/linkvalidator/Classes/Event/ModifyValidatorTaskEmailEvent.php+35 −3
- typo3/sysext/linkvalidator/Classes/QueryRestrictions/EditableRestriction.php+1 −3
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+57 −43
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+11 −3
- typo3/sysext/linkvalidator/Classes/Result/LinkAnalyzerResult.php3+19 −27
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+39 −43
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+3 −3
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+69 −44
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+95 −30
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php+43 −50
- typo3/sysext/linkvalidator/Tests/Unit/Configuration/LinkvalidatorConfigurationTest.phpnew+118 −0
- typo3/sysext/linkvalidator/ext_tables.php+1 −1
Review log 2748
Show 1123 earlier messages
-
Sybille Peters uploaded patch set 1 10/13/20, 16:27
-
TYPO3com voted on patch set 1 V +1 10/13/20, 16:47 Completed build in 16m 10s on Tue, 13 Oct, 04:47 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6488
-
Sybille Peters uploaded patch set 2 10/13/20, 17:27
-
Sybille Peters updated the commit message in patch set 3 10/13/20, 17:29
-
TYPO3com voted on patch set 3 V -1 10/13/20, 17:47 Completed build in 18m 15s on Tue, 13 Oct, 05:47 PM Test Summary: 73715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6492
-
TYPO3com voted on patch set 2 V -1 10/13/20, 17:49 Completed build in 21m 47s on Tue, 13 Oct, 05:49 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6491
-
Sybille Peters uploaded patch set 4 10/14/20, 11:18
-
TYPO3com voted on patch set 4 V -1 10/14/20, 11:38 Completed build in 19m 50s on Wed, 14 Oct, 11:38 AM Test Summary: 73707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6528
-
TYPO3com voted on patch set 4 V +1 10/14/20, 12:05 Completed build in 15m 36s on Wed, 14 Oct, 12:05 PM Test Summary: 73714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6531
-
TYPO3com commented on patch set 4 10/14/20, 12:14 Completed build in 16m 17s on Wed, 14 Oct, 12:14 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6532
-
Sybille Peters uploaded patch set 5 10/14/20, 12:23
-
Sybille Peters uploaded patch set 6 10/14/20, 12:24
-
TYPO3com voted on patch set 5 V +1 10/14/20, 12:42 Completed build in 19m 45s on Wed, 14 Oct, 12:42 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6533
-
TYPO3com commented on patch set 6 10/14/20, 12:43 Completed build in 18m 06s on Wed, 14 Oct, 12:43 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6534
-
Sybille Peters uploaded patch set 7 10/14/20, 17:08
-
TYPO3com voted on patch set 7 V -1 10/14/20, 17:23 Completed build in 14m 29s on Wed, 14 Oct, 05:23 PM Test Summary: 1 of 74189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6543
-
TYPO3com voted on patch set 7 V +1 10/14/20, 17:56 Completed build in 12m 23s on Wed, 14 Oct, 05:56 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6545
-
TYPO3com commented on patch set 7 10/14/20, 18:01 Completed build in 17m 13s on Wed, 14 Oct, 06:01 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6546
-
Sybille Peters uploaded patch set 8 10/15/20, 11:38
-
Sybille Peters commented on patch set 8 V +1 10/15/20, 11:41
Tested report, link checking and scheduler. -
Sybille Peters uploaded patch set 9 10/15/20, 11:43
-
TYPO3com voted on patch set 8 V +1 10/15/20, 11:51 Completed build in 13m 41s on Thu, 15 Oct, 11:51 AM Test Summary: 73725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6555
-
Sybille Peters uploaded patch set 10 10/15/20, 11:54
-
TYPO3com voted on patch set 9 V +1 10/15/20, 11:57 Completed build in 13m 52s on Thu, 15 Oct, 11:57 AM Test Summary: 73725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6556
-
TYPO3com voted on patch set 10 V +1 10/15/20, 12:05 Completed build in 11m 36s on Thu, 15 Oct, 12:05 PM Test Summary: 73725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6557
-
Sybille Peters commented on patch set 10 CR -1 10/17/20, 08:19
Needs more work to split off non-breaking changes and deprecate first. -
Sybille Peters uploaded patch set 11 10/18/20, 11:39
-
TYPO3com voted on patch set 11 V +1 10/18/20, 11:51 Completed build in 11m 48s on Sun, 18 Oct, 11:51 AM Test Summary: 73833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6625
-
Sybille Peters uploaded patch set 12 10/18/20, 12:08
-
TYPO3com voted on patch set 12 V +1 10/18/20, 12:22 Completed build in 13m 39s on Sun, 18 Oct, 12:22 PM Test Summary: 73833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6627
-
Benni Mack commented on patch set 12 10/18/20, 19:52
LinkvalidatorConfiguration.php:95since this configuration object is containing state, and you want to read from this configuration object, I'd rather go with a factory method ::createFromPageTsConfig(array $tsConfig); which sets all the values and returns a new object. the "almost empty constructor" here shows a bit of code-smell, if you want to refactor it anyway.LinkAnalyzerResult.php:99any reason why you removed the @param annotations? -
Sybille Peters commented on patch set 12 10/19/20, 12:29
LinkAnalyzerResult.php:99ReplyNo, that was a mistake. I believe I copy pasted something and it got removed. Will fix. -
Sybille Peters uploaded patch set 13 10/19/20, 12:52
-
Sybille Peters commented on patch set 13 10/19/20, 12:53
LinkvalidatorConfiguration.php:95ReplyDoneLinkAnalyzerResult.php:99ReplyI asked in Slack because I saw some @param getting removed entirely: https://typo3.slack.com/archives/C03AM9R17/p1602673091302100 Got answer: @params is used for the type hint only and does not have a useful description remove it, yes So, in this case, I would like it should get removed because it contains only type hints -
TYPO3com voted on patch set 13 V +1 10/19/20, 13:03 Completed build in 11m 39s on Mon, 19 Oct, 01:03 PM Test Summary: 73833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6654
-
Sybille Peters commented on patch set 13 V -1 10/19/20, 14:03
Still working on it -
Sybille Peters uploaded patch set 14 10/19/20, 17:34
-
Sybille Peters uploaded patch set 15 10/19/20, 17:42
-
TYPO3com voted on patch set 14 V +1 10/19/20, 17:47 Completed build in 12m 55s on Mon, 19 Oct, 05:47 PM Test Summary: 73851 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6658
-
TYPO3com voted on patch set 15 V -1 10/19/20, 17:56 Completed build in 14m 09s on Mon, 19 Oct, 05:56 PM Test Summary: 6 of 74336 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6659
-
Sybille Peters uploaded patch set 16 10/20/20, 18:21
-
TYPO3com voted on patch set 16 V -1 10/20/20, 18:36 Completed build in 14m 09s on Tue, 20 Oct, 06:36 PM Test Summary: 72125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6698
-
TYPO3com voted on patch set 16 V +1 10/20/20, 18:55 Completed build in 12m 55s on Tue, 20 Oct, 06:55 PM Test Summary: 73542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6699
-
Sybille Peters wrote 10/23/20, 17:17
Topic set to Linkvalidator -
Alexander Schnitzler commented on patch set 16 10/26/20, 09:42
tbh I think this patch does too much. I would split it into different patches, especially the type changes and architectural changes. -
Sybille Peters commented on patch set 16 10/26/20, 10:41
> Patch Set 16: > > tbh I think this patch does too much. I would split it into different patches, especially the type changes and architectural changes. I agree. I will do that. The reason it got bloated: there were several typecasts in various places and e.g. the "linktypes" was used inconsistently (sometimes numbered array, sometimes using linktypes as keys etc.), also the array / string inconsistency. The Configuration class makes all the conversions in one place. Without it I am afraid of introducing new bugs when I make changes. But I agree it is too much for one patch and with careful considerations and tests it should be possible. -
Sybille Peters marked it work in progress 10/26/20, 17:10
-
Sybille Peters abandoned the change 10/27/20, 11:04
Will split this up into smaller patches with one objective each.