Review main Abandoned

66133[TASK] Use strict type checking in linkvalidator

Sybille Peters CR 0 V 0 Expert +774 −250 updated 10/27/20, 11:04

Commit message

Use strict type checking in all internal classes within
linkvalidator. Add type declarations.

Always use pidList as array, not sometimes as string,
sometimes as array.

Introduce new class LinkvalidatorConfiguration to
encapsulate configuration handling.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 13

Review log 2748

Show 1123 earlier messages
  1. Sybille Peters uploaded patch set 1 10/13/20, 16:27

  2. TYPO3com voted on patch set 1 V +1 10/13/20, 16:47 Completed build in 16m 10s on Tue, 13 Oct, 04:47 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6488

  3. Sybille Peters uploaded patch set 2 10/13/20, 17:27

  4. Sybille Peters updated the commit message in patch set 3 10/13/20, 17:29

  5. TYPO3com voted on patch set 3 V -1 10/13/20, 17:47 Completed build in 18m 15s on Tue, 13 Oct, 05:47 PM Test Summary: 73715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6492

  6. TYPO3com voted on patch set 2 V -1 10/13/20, 17:49 Completed build in 21m 47s on Tue, 13 Oct, 05:49 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6491

  7. Sybille Peters uploaded patch set 4 10/14/20, 11:18

  8. TYPO3com voted on patch set 4 V -1 10/14/20, 11:38 Completed build in 19m 50s on Wed, 14 Oct, 11:38 AM Test Summary: 73707 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6528

  9. TYPO3com voted on patch set 4 V +1 10/14/20, 12:05 Completed build in 15m 36s on Wed, 14 Oct, 12:05 PM Test Summary: 73714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6531

  10. TYPO3com commented on patch set 4 10/14/20, 12:14 Completed build in 16m 17s on Wed, 14 Oct, 12:14 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6532

  11. Sybille Peters uploaded patch set 5 10/14/20, 12:23

  12. Sybille Peters uploaded patch set 6 10/14/20, 12:24

  13. TYPO3com voted on patch set 5 V +1 10/14/20, 12:42 Completed build in 19m 45s on Wed, 14 Oct, 12:42 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6533

  14. TYPO3com commented on patch set 6 10/14/20, 12:43 Completed build in 18m 06s on Wed, 14 Oct, 12:43 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6534

  15. Sybille Peters uploaded patch set 7 10/14/20, 17:08

  16. TYPO3com voted on patch set 7 V -1 10/14/20, 17:23 Completed build in 14m 29s on Wed, 14 Oct, 05:23 PM Test Summary: 1 of 74189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6543

  17. TYPO3com voted on patch set 7 V +1 10/14/20, 17:56 Completed build in 12m 23s on Wed, 14 Oct, 05:56 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6545

  18. TYPO3com commented on patch set 7 10/14/20, 18:01 Completed build in 17m 13s on Wed, 14 Oct, 06:01 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6546

  19. Sybille Peters uploaded patch set 8 10/15/20, 11:38

  20. Sybille Peters commented on patch set 8 V +1 10/15/20, 11:41

    Tested report, link checking and scheduler.
  21. Sybille Peters uploaded patch set 9 10/15/20, 11:43

  22. TYPO3com voted on patch set 8 V +1 10/15/20, 11:51 Completed build in 13m 41s on Thu, 15 Oct, 11:51 AM Test Summary: 73725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6555

  23. Sybille Peters uploaded patch set 10 10/15/20, 11:54

  1. TYPO3com voted on patch set 9 V +1 10/15/20, 11:57 Completed build in 13m 52s on Thu, 15 Oct, 11:57 AM Test Summary: 73725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6556

  2. TYPO3com voted on patch set 10 V +1 10/15/20, 12:05 Completed build in 11m 36s on Thu, 15 Oct, 12:05 PM Test Summary: 73725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6557

  3. Sybille Peters commented on patch set 10 CR -1 10/17/20, 08:19

    Needs more work to split off non-breaking changes and deprecate first.
  4. Sybille Peters uploaded patch set 11 10/18/20, 11:39

  5. TYPO3com voted on patch set 11 V +1 10/18/20, 11:51 Completed build in 11m 48s on Sun, 18 Oct, 11:51 AM Test Summary: 73833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6625

  6. Sybille Peters uploaded patch set 12 10/18/20, 12:08

  7. TYPO3com voted on patch set 12 V +1 10/18/20, 12:22 Completed build in 13m 39s on Sun, 18 Oct, 12:22 PM Test Summary: 73833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6627

  8. Benni Mack commented on patch set 12 10/18/20, 19:52

    LinkvalidatorConfiguration.php:95

    since this configuration object is containing state, and you want to read from this configuration object, I'd rather go with a factory method ::createFromPageTsConfig(array $tsConfig); which sets all the values and returns a new object. the "almost empty constructor" here shows a bit of code-smell, if you want to refactor it anyway.

    LinkAnalyzerResult.php:99

    any reason why you removed the @param annotations?
  9. Sybille Peters commented on patch set 12 10/19/20, 12:29

    LinkAnalyzerResult.php:99 Reply

    No, that was a mistake. I believe I copy pasted something and it got removed. Will fix.
  10. Sybille Peters uploaded patch set 13 10/19/20, 12:52

  11. Sybille Peters commented on patch set 13 10/19/20, 12:53

    LinkvalidatorConfiguration.php:95 Reply

    Done

    LinkAnalyzerResult.php:99 Reply

    I asked in Slack because I saw some @param getting removed entirely: https://typo3.slack.com/archives/C03AM9R17/p1602673091302100 Got answer: @params is used for the type hint only and does not have a useful description remove it, yes So, in this case, I would like it should get removed because it contains only type hints
  12. TYPO3com voted on patch set 13 V +1 10/19/20, 13:03 Completed build in 11m 39s on Mon, 19 Oct, 01:03 PM Test Summary: 73833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6654

  13. Sybille Peters commented on patch set 13 V -1 10/19/20, 14:03

    Still working on it
  14. Sybille Peters uploaded patch set 14 10/19/20, 17:34

  15. Sybille Peters uploaded patch set 15 10/19/20, 17:42

  16. TYPO3com voted on patch set 14 V +1 10/19/20, 17:47 Completed build in 12m 55s on Mon, 19 Oct, 05:47 PM Test Summary: 73851 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6658

  17. TYPO3com voted on patch set 15 V -1 10/19/20, 17:56 Completed build in 14m 09s on Mon, 19 Oct, 05:56 PM Test Summary: 6 of 74336 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6659

  18. Sybille Peters uploaded patch set 16 10/20/20, 18:21

  19. TYPO3com voted on patch set 16 V -1 10/20/20, 18:36 Completed build in 14m 09s on Tue, 20 Oct, 06:36 PM Test Summary: 72125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6698

  20. TYPO3com voted on patch set 16 V +1 10/20/20, 18:55 Completed build in 12m 55s on Tue, 20 Oct, 06:55 PM Test Summary: 73542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6699

  21. Sybille Peters wrote 10/23/20, 17:17

    Topic set to Linkvalidator
  22. Alexander Schnitzler commented on patch set 16 10/26/20, 09:42

    tbh I think this patch does too much. I would split it into different patches, especially the type changes and architectural changes.
  23. Sybille Peters commented on patch set 16 10/26/20, 10:41

    > Patch Set 16: > > tbh I think this patch does too much. I would split it into different patches, especially the type changes and architectural changes. I agree. I will do that. The reason it got bloated: there were several typecasts in various places and e.g. the "linktypes" was used inconsistently (sometimes numbered array, sometimes using linktypes as keys etc.), also the array / string inconsistency. The Configuration class makes all the conversions in one place. Without it I am afraid of introducing new bugs when I make changes. But I agree it is too much for one patch and with careful considerations and tests it should be possible.
  24. Sybille Peters marked it work in progress 10/26/20, 17:10

  25. Sybille Peters abandoned the change 10/27/20, 11:04

    Will split this up into smaller patches with one objective each.