Review main Abandoned

66134[WIP][BUGFIX] Fix FolderTree in Safari 14

Oli Bartsch CR 0 V 0 Easy +11 −3 updated 07/05/21, 06:28

Commit message

The HTML for the navigation iFrame is initially loaded
with `about:blank` set as source. The correct source
gets added via JavaScript.

On initial request following happens:

* ModuleMenu::openInNavFrame() is called with the FolderTree URL
* Because the given URL does not match the current ("about:blank")
URL, `Viewport.NavigationContainer.refresh()` is called after the new
URL was set as `src` attribute of the iFrame
* In the called `refresh()` function, the WindowProxy is reloaded
based on the new source.

The last step however seems not to work on latest Safari (14).
It's not totally clear why, maybe this has something to do with
the new lazyLoad feature, but Safari still loads the `about:blank`
which results in the empty body of the iFrame.

Side note: Safari never finishes loading of the `about:blank` content.

If we now wait a bit, Safari seems to accept the new URL and loads
the corresponding content.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 10/13/20, 16:40

  2. TYPO3com voted on patch set 1 V +1 10/13/20, 16:56 Completed build in 16m 36s on Tue, 13 Oct, 04:56 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6489

  3. Andreas Kienast commented on patch set 1 11/20/20, 09:59

    Removing the `reload()` calls in ModuleMenu.openInNavFrame() solves this specific issue as well. Im not sure about side-effects though
  4. Benni Mack commented on patch set 1 05/11/21, 19:12

    THis isn't needed anymore for v11 I guess.
  5. Benni Mack abandoned the change 07/05/21, 06:28

    abandoning this change for the time being