Review main Abandoned

66137[BUGFIX] Ensure message send loop breaks in case of success

Simon Gilli CR 0 V 0 Normal +106 −16 updated 10/14/20, 13:17

Commit message

This patch ensure the message send loop breaks after a message was sent
successfully. The doSend() method is rewritten to increase the
readability. Also a minimal unit test is added to verify the
functionality of the FileSpool.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 917

  1. Simon Gilli uploaded patch set 1 10/14/20, 08:13

  2. TYPO3com voted on patch set 1 V -1 10/14/20, 08:13 Completed build in 25s on Wed, 14 Oct, 08:13 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6512

  3. Simon Gilli marked it work in progress 10/14/20, 08:13

  4. Simon Gilli uploaded patch set 2 10/14/20, 08:15

  5. TYPO3com commented on patch set 2 10/14/20, 08:16 Completed build in 22s on Wed, 14 Oct, 08:16 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6513

  6. Simon Gilli uploaded patch set 3 10/14/20, 08:16

  7. TYPO3com voted on patch set 3 V +1 10/14/20, 08:27 Completed build in 11m 14s on Wed, 14 Oct, 08:27 AM Test Summary: 73721 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6514

  8. Simon Gilli uploaded patch set 4 10/14/20, 08:30

  9. Simon Gilli rebased onto patch set 5 10/14/20, 08:40

  10. TYPO3com voted on patch set 4 V +1 10/14/20, 08:42 Completed build in 12m 22s on Wed, 14 Oct, 08:42 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6515

  11. TYPO3com voted on patch set 5 V -1 10/14/20, 08:54 Completed build in 14m 30s on Wed, 14 Oct, 08:54 AM Test Summary: 73367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6516

  12. Simon Gilli uploaded patch set 6 10/14/20, 09:01

  13. TYPO3com voted on patch set 6 V -1 10/14/20, 09:22 Completed build in 20m 48s on Wed, 14 Oct, 09:22 AM Test Summary: 12 of 74219 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6520

  14. Simon Gilli uploaded patch set 7 10/14/20, 09:24

  15. TYPO3com voted on patch set 7 V -1 10/14/20, 10:08 Completed build in 44m 41s on Wed, 14 Oct, 10:08 AM Test Summary: 1 of 73759 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6522

  16. TYPO3com voted on patch set 7 V +1 10/14/20, 13:15 Completed build in 13m 23s on Wed, 14 Oct, 01:15 PM Test Summary: 73734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6538

  17. Simon Gilli abandoned the change 10/14/20, 13:17