Review main Merged

66138[TASK] Only set _ORIG_pid field for moved versioned records

Benni Mack CR +2 V +2 Normal +24 −57 updated 10/18/20, 12:25

Commit message

When using workspaces, the computed field "_ORIG_pid" is the
same value as "pid" when using the workspace-related methods

* PageRepository->versionOL()
* PageRepository->fixVersioningPid()
* BackendUtility::workspaceOL()
* BackendUtility::fixVersioningPid()

The field "_ORIG_uid" which keeps the UID of the versioned/workspace
record, is still set.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 917

  1. Benni Mack uploaded patch set 1 10/14/20, 09:12

  2. TYPO3com voted on patch set 1 V -1 10/14/20, 10:16 Completed build in 1h 01m 32s on Wed, 14 Oct, 10:16 AM Test Summary: 7 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6521

  3. TYPO3com commented on patch set 1 10/14/20, 10:32 Completed build in 2h 18m 56s on Wed, 14 Oct, 10:32 AM Test Summary: 6 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6521

  4. Benni Mack uploaded patch set 2 10/14/20, 11:04

  5. TYPO3com voted on patch set 2 V -1 10/14/20, 11:23 Completed build in 19m 40s on Wed, 14 Oct, 11:23 AM Test Summary: 71973 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6527

  6. TYPO3com voted on patch set 2 V +1 10/15/20, 15:26 Completed build in 4h 42m 08s on Thu, 15 Oct, 03:26 PM Test Summary: 73714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6527

  7. Benni Mack uploaded patch set 3 10/15/20, 15:28

  8. TYPO3com voted on patch set 3 V -1 10/15/20, 15:44 Completed build in 15m 27s on Thu, 15 Oct, 03:44 PM Test Summary: 6 of 74189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6563

  9. Benni Mack uploaded patch set 4 10/15/20, 15:47

  10. TYPO3com voted on patch set 4 V -1 10/15/20, 16:03 Completed build in 15m 38s on Thu, 15 Oct, 04:03 PM Test Summary: 3 of 74189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6564

  11. Benni Mack uploaded patch set 5 10/16/20, 08:44

  12. TYPO3com voted on patch set 5 V +1 10/16/20, 08:58 Completed build in 13m 04s on Fri, 16 Oct, 08:58 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6569

  13. Christian Kuhn uploaded patch set 6 10/17/20, 12:44

  14. Christian Kuhn voted on patch set 6 V +1 CR +1 10/17/20, 12:45

  15. TYPO3com voted on patch set 6 V +1 10/17/20, 13:11 Completed build in 23m 19s on Sat, 17 Oct, 01:11 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6615

  16. Daniel Goerz voted on patch set 6 V +2 CR +2 10/18/20, 12:25

  17. Daniel Goerz merged patch set 7 10/18/20, 12:25