Review main Merged

66140[TASK] Use the current request to resolve TSFE in redirects

Benni Mack CR +2 V +2 Normal +67 −25 updated 10/22/20, 15:04

Commit message

The RedirectService should have a ServerRequestInterface
object that can properly set up TSFE when linking to pages.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1016

  1. Benni Mack uploaded patch set 1 10/14/20, 11:22

  2. TYPO3com voted on patch set 1 V -1 10/14/20, 11:41 Completed build in 14m 19s on Wed, 14 Oct, 11:41 AM Test Summary: 48 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6530

  3. Benni Mack uploaded patch set 2 10/21/20, 21:58

  4. TYPO3com voted on patch set 2 V +1 10/21/20, 22:15 Completed build in 16m 09s on Wed, 21 Oct, 10:15 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6770

  5. Daniel Goerz commented on patch set 2 10/22/20, 10:05

    RedirectService.php:229

    Why public?
  6. Benni Mack uploaded patch set 3 10/22/20, 10:18

  7. TYPO3com voted on patch set 3 V +1 10/22/20, 10:40 Completed build in 22m 01s on Thu, 22 Oct, 10:40 AM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6786

  8. Georg Ringer voted on patch set 3 CR +1 10/22/20, 12:24

  9. Benni Mack commented on patch set 3 10/22/20, 12:49

    RedirectService.php:229 Reply Unresolved

    good point
  10. Oli Bartsch uploaded patch set 4 10/22/20, 13:59

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 10/22/20, 13:59

  12. TYPO3com voted on patch set 4 V -1 10/22/20, 14:24 Completed build in 19m 55s on Thu, 22 Oct, 02:24 PM Test Summary: 1 of 73979 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6800

  13. TYPO3com voted on patch set 4 V +1 10/22/20, 14:48 Completed build in 1h 04m 18s on Thu, 22 Oct, 02:48 PM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6800

  14. TYPO3com commented on patch set 4 10/22/20, 14:51 Completed build in 16m 49s on Thu, 22 Oct, 02:51 PM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6803

  15. Daniel Goerz voted on patch set 4 V +2 CR +2 10/22/20, 15:03

  16. Daniel Goerz merged patch set 5 10/22/20, 15:04