Review 9.5 Merged

66143[BUGFIX] Migrate the most accurate RealURL page path to page slugs

Mathias Brodala CR +2 V +2 Easy +1 −1 updated 10/19/20, 19:46

Commit message

Use the same sorting logic for page paths RealURL used, even if not consistently.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1320

  1. Mathias Brodala uploaded patch set 1 10/15/20, 08:20

  2. Mathias Brodala updated the commit message in patch set 2 10/15/20, 08:32

  3. TYPO3com voted on patch set 1 V +1 10/15/20, 08:37 Completed build in 17m 01s on Thu, 15 Oct, 08:37 AM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-835

  4. TYPO3com voted on patch set 2 V +1 10/15/20, 08:48 Completed build in 15m 48s on Thu, 15 Oct, 08:48 AM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-836

  5. Rémy DANIEL commented on patch set 2 10/15/20, 13:22

    PopulatePageSlugs.php:238

    I would keep a sorting by expire ASC. This will prevent to fetch a expired path over an active one.
  6. Mathias Brodala commented on patch set 2 10/15/20, 14:04

    PopulatePageSlugs.php:238 Reply Unresolved

    As mentioned in Slack we need to use exactly the same query RealURL does. Anything else leads to errors like this. So I'd really like to avoid anything "smart" added here.
  7. Mathias Brodala commented on patch set 3 10/15/20, 14:38

    Published edit on patch set 2.
  8. Mathias Brodala updated the commit message in patch set 4 10/15/20, 14:38

  9. Mathias Brodala uploaded patch set 5 10/15/20, 14:43

  10. TYPO3com voted on patch set 3 V +1 10/15/20, 14:51 Completed build in 13m 35s on Thu, 15 Oct, 02:51 PM Test Summary: 75191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-838

  11. TYPO3com voted on patch set 4 V +1 10/15/20, 14:55 Completed build in 17m 06s on Thu, 15 Oct, 02:55 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-839

  12. TYPO3com voted on patch set 5 V +1 10/15/20, 15:03 Completed build in 18m 31s on Thu, 15 Oct, 03:03 PM Test Summary: 75190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-840

  13. Mathias Brodala abandoned the change 10/15/20, 15:19

    Replaced by https://review.typo3.org/c/Packages/TYPO3.CMS/+/66148 which targets 10.4 first.
  14. Anja Leichsenring restored the change 10/19/20, 19:17

  15. Anja Leichsenring uploaded patch set 6 10/19/20, 19:17

  16. Anja Leichsenring updated the commit message in patch set 7 10/19/20, 19:17

  17. TYPO3com voted on patch set 6 V +1 10/19/20, 19:32 Completed build in 14m 56s on Mon, 19 Oct, 07:32 PM Test Summary: 75191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-841

  18. TYPO3com voted on patch set 7 V +1 10/19/20, 19:36 Completed build in 19m 06s on Mon, 19 Oct, 07:36 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-842

  19. Anja Leichsenring voted on patch set 7 V +2 CR +2 10/19/20, 19:46

  20. Anja Leichsenring merged patch set 8 10/19/20, 19:46