Review main Merged

66144[TASK] Remove unused log argument in DataHandler

Benni Mack CR +2 V +2 Easy +5 −6 updated 10/15/20, 10:38

Commit message

Since TYPO3 v10 the history is connected via
the correlationId in DataHandler and the setHistory()
method does not need the third argument anymore.

This change removes the third argument, and removes
the only two usages in Workspaces.

The method is marked as internal, and the argument
has no value. For this reason, we can remove the
method argument.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 10/15/20, 09:37

  2. Benni Mack updated the commit message in patch set 2 10/15/20, 09:41

  3. Benni Mack voted on patch set 2 V +2 CR +2 10/15/20, 09:42

  4. Benni Mack voted on patch set 2 V 0 CR 0 10/15/20, 09:42

  5. TYPO3com voted on patch set 1 V +1 10/15/20, 09:52 Completed build in 14m 21s on Thu, 15 Oct, 09:52 AM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6549

  6. TYPO3com voted on patch set 2 V +1 10/15/20, 09:56 Completed build in 14m 33s on Thu, 15 Oct, 09:56 AM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6550

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 10/15/20, 10:30

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/15/20, 10:38

  9. Christian Kuhn merged patch set 3 10/15/20, 10:38