Review 9.5 Merged

66146[BUGFIX] Make external link checking more robust

Sybille Peters CR +2 V +2 Easy +23 −14 updated 11/20/20, 13:37

Commit message

Previously, some URLs could result in errors which were not caught and
caused the link checking task to abort.

ExternalLinktype::preprocessUrl() now returns original URL in case
of any error, catches errors and exception and does some sanity
checking of parsed URLs before using the results.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Rémy DANIEL +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Rémy DANIEL +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1824

  1. Sybille Peters uploaded patch set 1 10/15/20, 11:59

  2. TYPO3com voted on patch set 1 V +1 10/15/20, 12:14 Completed build in 15m 18s on Thu, 15 Oct, 12:14 PM Test Summary: 75204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-837

  3. Sybille Peters voted on patch set 1 V +1 10/22/20, 11:12

  4. Sybille Peters wrote 10/23/20, 17:17

    Topic set to Linkvalidator
  5. Alexander Schnitzler commented on patch set 1 10/26/20, 09:57

    ExternalLinktype.php:224 Unresolved

    Please do not use a bool condition check for non booleans. $parts['host'] should be a non empty string. So I would adjust this check as follows: > if (((string)($parts['host'] ?? '')) !== '') Alternatively, evaluate $parts['host'] out of this condition. --- Further, you could revert this if statement and early return here.
  6. Sybille Peters commented on patch set 1 10/26/20, 10:45

    > Patch Set 1: > > (1 comment) Problem is, this is a backport of a change that already got merged as "master, 10.4". I added this patch, after someone complained in an issue, that is was not backported to 9.5. Is it better now to create a completely new patch because the change should probably be done in master & 10.4 too?
  7. Alexander Schnitzler commented on patch set 1 10/26/20, 10:48

    > Patch Set 1: > > > Patch Set 1: > > > > (1 comment) > > Problem is, this is a backport of a change that already got merged as "master, 10.4". I added this patch, after someone complained in an issue, that is was not backported to 9.5. > > Is it better now to create a completely new patch because the change should probably be done in master & 10.4 too? Ok, too bad. Then ignore my comment for this patch.
  8. Sybille Peters uploaded patch set 2 10/26/20, 16:51

  9. TYPO3com voted on patch set 2 V +1 10/26/20, 17:05 Completed build in 13m 52s on Mon, 26 Oct, 05:05 PM Test Summary: 75204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-855

  10. Sybille Peters uploaded patch set 3 10/26/20, 17:52

  11. TYPO3com voted on patch set 3 V +1 10/26/20, 18:08 Completed build in 15m 50s on Mon, 26 Oct, 06:08 PM Test Summary: 75204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-856

  12. Oliver Klee commented on patch set 3 10/26/20, 18:23

    ExternalLinktype.php:224

    If $parts['host'] is a non-string, we will still have the non-string further down. I propsose to put this in a local variable $host. (We'll also need tests for the non-string cases.)
  13. Sybille Peters uploaded patch set 4 11/19/20, 10:11

  14. Sybille Peters commented on patch set 4 11/19/20, 10:19

    ExternalLinktype.php:224 Reply

    $parts['host'] being a non-string makes no sense at all. I don't know if this is even possible. The casting is only done for paranoia purposes because the docs for parse_url() are not explicit about this. If 'host' is empty or something that evaluates to '' any further evaluation makes no sense. I changed it now so that $host is a variable which also makes the code more readable (I think). In any case, this is a bugfix which was already merged for master and 10.4 and I would like to get this merged because several people already reported this as a problem in 9 - it it not just one URL that cannot get evaluated, it completely terminates the link checking. AFTER this is merged, I would like to unify the changes for master - 10.4 and 9.5 since the code now deviates.
  15. Sybille Peters uploaded patch set 5 11/19/20, 10:24

  16. TYPO3com voted on patch set 4 V -1 11/19/20, 10:29 Completed build in 13m 02s on Thu, 19 Nov, 10:29 AM Test Summary: 18 of 75906 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-912

  17. TYPO3com voted on patch set 5 V +1 11/19/20, 12:02 Completed build in 12m 45s on Thu, 19 Nov, 12:02 PM Test Summary: 75306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-914

  18. Rémy DANIEL voted on patch set 5 V +1 CR +1 11/20/20, 12:06

  19. Anja Leichsenring updated the commit message in patch set 6 11/20/20, 13:12

  20. TYPO3com voted on patch set 6 V +1 11/20/20, 13:34 Completed build in 21m 23s on Fri, 20 Nov, 01:34 PM Test Summary: 75306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-918

  21. Rémy DANIEL voted on patch set 6 V +1 CR +1 11/20/20, 13:35

  22. Christian Kuhn commented on patch set 6 V +1 CR +1 11/20/20, 13:37

    master / v10 version:
  23. Anja Leichsenring voted on patch set 6 V +2 CR +2 11/20/20, 13:37

  24. Anja Leichsenring merged patch set 7 11/20/20, 13:37