Review main Merged

66149[TASK] Assert clean reference index in workspace tests

Christian Kuhn CR +2 V +2 Impossible +13407 −12263 updated 10/16/20, 12:00

Commit message

With #92467 'live' DataHandler tests have been extended
to verify the reference index is clean after operations.

The patch enables this check for most of the workspace
related functional tests. This proofs most scenarios
are ok when it comes to workspaces and reference index.

Some workspace functionals disable this integrity check
by setting $this->assertCleanReferenceIndex = false;
since reference index is still buggy in some cases. Most
cases are related to broken mm relation handling and in
scenarios where a live page is deleted and a workspace
version exists. Those cases will be fixed with further
patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 659

Show 639 more files

Review log 712

  1. Christian Kuhn uploaded patch set 1 10/15/20, 17:08

  2. TYPO3com voted on patch set 1 V -1 10/15/20, 17:08 Completed build in 29s on Thu, 15 Oct, 05:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6566

  3. Christian Kuhn uploaded patch set 2 10/15/20, 17:10

  4. TYPO3com voted on patch set 2 V -1 10/15/20, 17:23 Completed build in 12m 57s on Thu, 15 Oct, 05:23 PM Test Summary: 179 of 74291 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6567

  5. Christian Kuhn updated the commit message in patch set 3 10/15/20, 17:31

  6. TYPO3com voted on patch set 3 V -1 10/15/20, 17:44 Completed build in 12m 46s on Thu, 15 Oct, 05:44 PM Test Summary: 179 of 74291 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6568

  7. Christian Kuhn uploaded patch set 4 10/16/20, 11:04

  8. TYPO3com voted on patch set 4 V -1 10/16/20, 11:18 Completed build in 14m 33s on Fri, 16 Oct, 11:18 AM Test Summary: 513 of 74291 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6574

  9. Christian Kuhn uploaded patch set 5 10/16/20, 11:42

  10. TYPO3com voted on patch set 5 V +1 10/16/20, 11:55 Completed build in 12m 47s on Fri, 16 Oct, 11:55 AM Test Summary: 73805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6576

  11. Benni Mack commented on patch set 5 V +2 CR +2 10/16/20, 11:59

    EXT:workspaces only and tests-only - will merge directly.
  12. Benni Mack merged patch set 6 10/16/20, 12:00