Review main Merged

66151[BUGFIX] Correctly create section menu for pages showing content of other pages

Christoph Lehmann CR +2 V +2 Easy +8 −0 updated 02/16/21, 11:21

Commit message

This commit fills the section menu if no page is configured in the ce
and the current page uses the content of another page

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Christoph Lehmann uploaded patch set 1 10/16/20, 11:09

  2. TYPO3com voted on patch set 1 V +1 10/16/20, 11:25 Completed build in 16m 30s on Fri, 16 Oct, 11:25 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6575

  3. Simon Gilli commented on patch set 1 10/16/20, 11:42

    This message is not conforming to https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html#commitmessage. You should describe what this patch changes and not describe the issue, that's part of the ticket. E.g. Correctly create section menu for pages showing content of other pages
    Was this bug introduced after 9.5.0? If no, back port is normally not allowed.
  4. Christoph Lehmann updated the commit message in patch set 2 10/16/20, 11:56

  5. Christoph Lehmann commented on patch set 2 10/16/20, 11:59

    Reply

    Done

    Reply

    No, it's alredy in 8.7. I removed 9.5
  6. TYPO3com voted on patch set 2 V +1 10/16/20, 12:08 Completed build in 11m 22s on Fri, 16 Oct, 12:08 PM Test Summary: 73720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6577

  7. Benni Mack voted on patch set 2 CR +1 10/16/20, 15:28

  8. Riccardo De Contardi commented on patch set 2 V +1 02/13/21, 15:54

    The patch seems to work for "Section index" ([section_index]) ,but not for "Section index of subpages from selected pages" ( [menu_section_pages] )
  9. Richard Haeser voted on patch set 2 V +2 CR +2 02/16/21, 11:21

  10. Richard Haeser merged patch set 3 02/16/21, 11:21