Review main Merged

66152[BUGFIX] Workspace and reference index fixes

Christian Kuhn CR +2 V +2 Hard +161 −317 updated 10/19/20, 17:41

Commit message

This drops all left over calls that suppress the refindex
integrity checks in DataHandler functional tests, except those
within ManyToMany tests: This area needs more work before the
reference index can be fixed.

Two bugs indirectly related to the reference index are fixed
along the way, those can't be separated as standalone patches:

* When a translated page is deleted in workspaces, the
  DataHandler deleted live records on this page, too. This
  is fixed by adding a proper db restriction. This also
  fixes the reference index state in this scenario.

* When publishing a delete placeholder that has inline children,
  workspace delete placeholders are created for the children, which
  is wrong. This happens because the user is not set to the live
  workspace during the publish operation. Temporarily changing the
  user workspace to live not only fixes the reference index, but
  does not create the bogus inline children placeholder records
  anymore, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • David Steeb +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 49

Show 29 more files

Review log 1727

Show 12 earlier messages
  1. Christian Kuhn uploaded patch set 1 10/16/20, 14:22

  2. TYPO3com voted on patch set 1 V -1 10/16/20, 14:23 Completed build in 31s on Fri, 16 Oct, 02:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6580

  1. Christian Kuhn uploaded patch set 2 10/16/20, 14:26

  2. Christian Kuhn uploaded patch set 3 10/16/20, 14:37

  3. TYPO3com voted on patch set 2 V -1 10/16/20, 14:39 Completed build in 12m 25s on Fri, 16 Oct, 02:39 PM Test Summary: 3 of 74291 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6581

  4. TYPO3com voted on patch set 3 V +1 10/16/20, 14:49 Completed build in 12m 30s on Fri, 16 Oct, 02:49 PM Test Summary: 73806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6582

  5. Christian Kuhn uploaded patch set 4 10/16/20, 16:04

  6. TYPO3com voted on patch set 4 V -1 10/16/20, 16:21 Completed build in 16m 54s on Fri, 16 Oct, 04:21 PM Test Summary: 72 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6586

  7. Christian Kuhn uploaded patch set 5 10/16/20, 17:29

  8. TYPO3com voted on patch set 5 V -1 10/16/20, 17:42 Completed build in 13m 07s on Fri, 16 Oct, 05:42 PM Test Summary: 42 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6589

  9. Christian Kuhn uploaded patch set 6 10/16/20, 18:11

  10. TYPO3com voted on patch set 6 V -1 10/16/20, 18:26 Completed build in 14m 53s on Fri, 16 Oct, 06:26 PM Test Summary: 12 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6590

  11. Christian Kuhn uploaded patch set 7 10/16/20, 18:30

  12. TYPO3com voted on patch set 7 V -1 10/16/20, 18:42 Completed build in 11m 51s on Fri, 16 Oct, 06:42 PM Test Summary: 2 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6591

  13. Christian Kuhn uploaded patch set 8 10/18/20, 12:46

  14. TYPO3com voted on patch set 8 V -1 10/18/20, 12:47 Completed build in 28s on Sun, 18 Oct, 12:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6630

  15. Christian Kuhn uploaded patch set 9 10/18/20, 13:17

  16. TYPO3com voted on patch set 9 V -1 10/18/20, 13:29 Completed build in 11m 51s on Sun, 18 Oct, 01:29 PM Test Summary: 2 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6631

  17. Christian Kuhn uploaded patch set 10 10/18/20, 15:02

  18. TYPO3com voted on patch set 10 V +1 10/18/20, 15:15 Completed build in 12m 40s on Sun, 18 Oct, 03:15 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6634

  19. Christian Kuhn commented on patch set 10 CR -1 10/18/20, 15:16

    Let's see if I can stabilize the 10.4 version before we merge master.
  20. Christian Kuhn voted on patch set 10 CR 0 10/19/20, 11:34

  21. Benni Mack voted on patch set 10 V +1 CR +1 10/19/20, 13:03

  22. David Steeb voted on patch set 10 CR +1 10/19/20, 13:07

  23. Anja Leichsenring voted on patch set 10 V +1 CR +1 10/19/20, 17:41

  24. Christian Kuhn voted on patch set 10 V +2 CR +2 10/19/20, 17:41

  25. Christian Kuhn merged patch set 11 10/19/20, 17:41