Review main Abandoned

66154[FEATURE] Filter page tree by uid

Sybille Peters CR 0 V 0 Normal +53 −16 updated 03/27/22, 08:42

Commit message

It is now possible to filter the pagetree by providing an
explicit uid.

This can be done by entering "uid=" and the uid in the search
field.

If the "uid=" is not used, the behaviour is the same as before.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 2933

Show 68 earlier messages
  1. Sybille Peters uploaded patch set 1 10/16/20, 16:02

  2. Sybille Peters uploaded patch set 2 10/16/20, 16:04

  3. TYPO3com voted on patch set 1 V -1 10/16/20, 16:15 Completed build in 13m 38s on Fri, 16 Oct, 04:15 PM Test Summary: 1 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6585

  4. TYPO3com voted on patch set 2 V +1 10/16/20, 16:25 Completed build in 20m 46s on Fri, 16 Oct, 04:25 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6587

  5. Guido Schmechel commented on patch set 2 10/20/20, 17:21

    First of all: The feature is a great idea. My question would be, should we extend it again per psr14 event? For me it is conceivable to search for further fields, for example, as the integrator would like to extend it for himself. Context: We do have extensions in the pages table and could filter in the PageTree. What do you think about it?
  6. Sybille Peters commented on patch set 2 10/20/20, 18:10

    > Patch Set 2: > > First of all: The feature is a great idea. My question would be, should we extend it again per psr14 event? For me it is conceivable to search for further fields, for example, as the integrator would like to extend it for himself. > > Context: We do have extensions in the pages table and could filter in the PageTree. > > What do you think about it? Making this extensible is of course a cool idea. In that case, it would also be cool to be able to change the hint. My intention was to find a "small" solution that would not require too many changes. Sometimes larger changes will take a long time to get finished and then they might never make into 11. Also, there is another issue open https://forge.typo3.org/issues/36075 which would handle the filter in a more sophisticated way. From point of view of a "cleaner" solution, it might be a good idea to combine my patch with https://forge.typo3.org/issues/36075. From my point of view, I would rather have my solution because the other solution may never get finished for 11. But I would be interested in your recommendations.
  7. Guido Schmechel commented on patch set 2 10/21/20, 10:19

    Thank you for your detailed elaboration! Since there is practically a second ticket (36075), you could create two patches. Patch 1: Your base uid solution Patch 2: Extensibility of the filter And I think we could also make it into the 11 LTS with Patch 2. There is still time ;-)
  8. Sybille Peters commented on patch set 2 10/21/20, 10:46

    > Patch Set 2: > > Thank you for your detailed elaboration! Since there is practically a second ticket (36075), you could create two patches. > > Patch 1: Your base uid solution > Patch 2: Extensibility of the filter > > And I think we could also make it into the 11 LTS with Patch 2. There is still time ;-) From my end: I supply patch as is. I am happy to make small improvements in code style or optimizations (if there is anything to improve). I don't have time to work on the more complex solution, I currently focus mostly on linkvalidator (where I am already more familiar with code and have lots of ideas for improvements). I saw that this solution (or something similar) was already requested more than once in the past (see related issues). So, for a more complex solution - I would be happy if someone does it, just won't be me at the moment. Also, for making things configurable: I think if the solution already is very good, people won't have the itch that much to override things, which only makes everything more complex.
  1. Guido Schmechel commented on patch set 2 V +1 CR +1 10/21/20, 16:28

    Short question: What do you think about "Enter search term or uid=Page UID"? Simply to eliminate ambiguities. But I leave that to you others. Basically I am fine with this patch ;-)
  2. Sybille Peters uploaded patch set 3 10/21/20, 18:23

  3. Sybille Peters commented on patch set 3 10/21/20, 18:24

    > Patch Set 2: Verified+1 Code-Review+1 > > Short question: What do you think about "Enter search term or uid=Page UID"? Simply to eliminate ambiguities. > > But I leave that to you others. Basically I am fine with this patch ;-) I like the new text better too. I changed the text.
  4. TYPO3com voted on patch set 3 V +1 10/21/20, 18:35 Completed build in 11m 35s on Wed, 21 Oct, 06:35 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6759

  5. Guido Schmechel voted on patch set 3 V +1 CR +1 10/21/20, 19:14

  6. Christian Kuhn commented on patch set 3 10/22/20, 14:40

    How does this search react in workspaces if pages have been changed in ws or moved?
  7. Sybille Peters commented on patch set 3 10/22/20, 17:07

    > Patch Set 3: > > How does this search react in workspaces if pages have been changed in ws or moved? It does not really change anything in the way the search is performed. It rather does not do the additional search in other fields if 'uid=' is given. So if this would not work with workspaces, I assume, the already existing search would not either.
  8. Claus Due commented on patch set 3 10/24/20, 09:34

    I like the idea here but I find myself thinking if we should make it even more generic so you can filter by any (valid TCA) property, e.g.: no_index=1 slug=mypage hidden=1 This might bring a significant benefit in being able to get overviews of all pages configured in a certain way, in addition to being able to search for specific UIDs. Much like Solr has the "field:somevalue" syntax for filters!
  9. Sybille Peters commented on patch set 3 10/24/20, 09:56

    > Patch Set 3: > > I like the idea here but I find myself thinking if we should make it even more generic so you can filter by any (valid TCA) property, e.g.: > > no_index=1 > slug=mypage > hidden=1 > > This might bring a significant benefit in being able to get overviews of all pages configured in a certain way, in addition to being able to search for specific UIDs. > > Much like Solr has the "field:somevalue" syntax for filters! I will add some more of the other suggestions and screenshots from Twitter to the issue. Guido already made the suggestion of making it configurable via event. I also like my idea (see screenshots which I will add to issue) where you get a dropdown list to choose from with some suggestions. The problem was - the functionality gets more complex and I don't have that much time currently. What I can do is make small proof-of-concepts or JSfiddles and find someone who can create a patch from this initial idea which will (hopefully) actually get merged. What I also find very cool - you could also have "lv=external" for example or "lv=all" or just "lv=" to show only pages with existing broken links from linkvalidator, for example. The possibilities are endless!
  10. Sybille Peters commented on patch set 3 10/24/20, 10:02

    > > > > Much like Solr has the "field:somevalue" syntax for filters! > I also like the Solr (or originally Lucene) query syntax very much. https://lucene.apache.org/core/2_9_4/queryparsersyntax.html Unfortunately, people are too much used to Google and "the simple way" nowadays to be able to use these things. Hence my suggestions in the dropdown. I want these things to be useful for editors too!!! They are not stupid - they will be able to use it if it is intuitive.
  11. Ingo Fabbri commented on patch set 3 10/24/20, 12:11

    I am not a friend of this particular approach. uid=123 hidden=1 To make it clear, it is a custom query I would suggest we need to start the filter with a special character to make the intention clear. E.g. "=" or double-colon So for the uid filter: =uid:123 or the other way round :uid=123 This generic approach would make it possible to combine filters: =uid:123&hidden:0 or respectively :uid=123&hidden=0
  12. Ingo Fabbri commented on patch set 3 CR -1 10/24/20, 12:21

    PageTreeRepository.php:504

    These kind of state-variables increase the cognitive load. See if-condition below

    PageTreeRepository.php:514 Unresolved

    As mentioned above, cognitive load. "not uid only" - so the regular case...
  13. Ingo Fabbri commented on patch set 3 10/24/20, 12:22

    > Patch Set 3: > > I like the idea here but I find myself thinking if we should make it even more generic so you can filter by any (valid TCA) property, e.g.: > > no_index=1 > slug=mypage > hidden=1 > > This might bring a significant benefit in being able to get overviews of all pages configured in a certain way, in addition to being able to search for specific UIDs. > > Much like Solr has the "field:somevalue" syntax for filters! full ack
  14. Claus Due commented on patch set 3 10/24/20, 12:26

    > Patch Set 3: > > I am not a friend of this particular approach. > > uid=123 > hidden=1 > > To make it clear, it is a custom query I would suggest we need to start the filter with a special character to make the intention clear. E.g. "=" or double-colon > > So for the uid filter: > > =uid:123 > > or the other way round > > :uid=123 > > This generic approach would make it possible to combine filters: > > =uid:123&hidden:0 > > or respectively > > :uid=123&hidden=0 There's really no need for that, and making the search syntax even more esoteric doesn't seem like a good solution to me. Assumption: it is extremely rare that any site would use a syntax like "foo=xyz" in their page titles. Given this assumption it is more than adequately safe to determine that a search query that has "foo=xyz" means "show me results where field 'foo' has value of 'xyz'" as opposed to "show me pages where title contains foo=xyz". As for the multiple filters, consider the following: * hidden=1 sometext # find hidden pages with title containing "sometext" * hidden=1 slug=detail # find hidden pages which have a page slug value of "detail" * no_index=1 type=shortcut # find shortcuts set to "no indexing" This query syntax also would mean that you can put the title first and then refine your search: * First search: "mypage" # yields 20+ results * Second search "mypage hidden=1" # yields a couple of results, title match and hidden IMHO: simpler is better. Complex syntax subtracts from usability.
  15. Sybille Peters uploaded patch set 4 11/22/20, 19:17

  16. Sybille Peters wrote 11/22/20, 19:18

    Description of patch set 4 set to "Minor code change to reduce cognitive load"
  17. Sybille Peters commented on patch set 4 11/22/20, 19:23

    Btw, there is a nice feature in the Settings -> System maintainers where you can select the maintainers from a dropdown list and they are displayed, visibly separated. If something like this could be utilized here, where for example =uid: or uid= is selected and you just have to add the uid itself, the problem of esoteric syntax or not would be more irrelevant. It does not look like this patch will get merged. I would like to work on another patch to add the event. This would be more flexible and I could also use this for linkvalidator.
  18. TYPO3com voted on patch set 4 V +1 11/22/20, 19:28 Completed build in 10m 46s on Sun, 22 Nov, 07:28 PM Test Summary: 32390 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7511

  19. Sybille Peters commented on patch set 4 11/03/21, 20:39

    PageTreeRepository.php:504 Reply Unresolved

    Sorry about late reply. I wasn't sure if it was a good idea to keep working on this patch as the solution seemed controversial. But we might as well get the code cleaned up. Do you have a suggestion how to handle this differently?
  20. Sybille Peters wrote 11/03/21, 21:19

    Topic set to experimental UI
  21. Benni Mack wrote 11/29/21, 10:14

    Change destination moved from master to main
  22. Benni Mack updated the commit message in patch set 5 11/29/21, 13:39

  23. Benni Mack commented on patch set 5 12/22/21, 10:17

    @sybille: how to continue here?
  24. Sybille Peters abandoned the change 12/22/21, 10:49

  25. Sybille Peters commented on patch set 5 03/27/22, 08:42

    I think it would be best to work on this first with the usability group. The patch has been abandoned.

    Reply

    I don't know. I will abandon for now.