Review main Merged

66156[BUGFIX] Mark page for previewing when admin panel is active

Benni Mack CR +2 V +2 Easy +13 −8 updated 10/21/20, 09:04

Commit message

When the admin panel is active, the rendered page should always
be marked as "preview mode" so TSFE will later set
TSFE->no_cache which then allows to not store anything
in the Page cache.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Sybille Peters +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Benni Mack uploaded patch set 1 10/16/20, 22:54

  2. Benni Mack updated the commit message in patch set 2 10/16/20, 22:56

  3. TYPO3com voted on patch set 1 V +1 10/16/20, 23:08 Completed build in 13m 54s on Fri, 16 Oct, 11:08 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6592

  4. TYPO3com voted on patch set 2 V +1 10/16/20, 23:17 Completed build in 19m 14s on Fri, 16 Oct, 11:17 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6593

  5. Sybille Peters commented on patch set 2 V -1 10/17/20, 06:04

    I can still reproduce the problem with hidden content: 1. Enable "Show hidden records" in admin panel 2. Refresh cache + reload (CTRL-SHIFT-r) 3. In different browser, relaod page: hidden ce are rendered
  6. Andreas Kienast uploaded patch set 3 10/17/20, 09:06

  7. TYPO3com voted on patch set 3 V +1 10/17/20, 09:22 Completed build in 15m 45s on Sat, 17 Oct, 09:22 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6596

  8. Sybille Peters commented on patch set 3 V +1 10/17/20, 11:32

    Same procedure for testing: looks good :)
  9. Daniel Goerz voted on patch set 3 CR +1 10/18/20, 12:22

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 10/19/20, 18:56

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/19/20, 18:57

  12. Anja Leichsenring merged patch set 4 10/19/20, 18:57

  13. Sybille Peters commented on patch set 4 10/21/20, 09:04

    Backport for 9.5 is still missing.