Review main Merged

66157[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Controller

Daniel Goerz CR +2 V +2 Normal +44 −38 updated 10/20/20, 08:00

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 1721

  1. Daniel Goerz uploaded patch set 1 10/17/20, 09:05

  2. Daniel Goerz wrote 10/17/20, 09:05

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 10/17/20, 09:13

  4. TYPO3com voted on patch set 1 V +1 10/17/20, 09:16 Completed build in 11m 45s on Sat, 17 Oct, 09:16 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6595

  5. Oliver Klee voted on patch set 1 CR +1 10/17/20, 09:18

  6. Daniel Goerz uploaded patch set 2 10/17/20, 13:16

  7. Daniel Goerz voted on patch set 2 V +1 CR +1 10/17/20, 13:16

  8. Oliver Klee voted on patch set 2 CR +1 10/17/20, 13:20

  9. TYPO3com voted on patch set 2 V +1 10/17/20, 13:48 Completed build in 14m 38s on Sat, 17 Oct, 01:48 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6621

  10. Benni Mack commented on patch set 2 10/19/20, 18:35

    TableController.php:602

    is_countable is a function that was introduced in PHP 7.3
  11. Christian Kuhn commented on patch set 2 CR -1 10/19/20, 18:42

    TableController.php:602 Reply

    good catch. symfony/polyfill-php73 brings it, but it is an indirect dependency and i think we shouldn't make it an explicit dependency just for this case, especially not for 10.4 (and in master it may resolve itself soon if we raise to >=7.4)
  12. Daniel Goerz commented on patch set 2 V 0 CR 0 10/19/20, 21:21

    TableController.php:602 Reply Unresolved

    Nice one. is_array() should do.
  13. Daniel Goerz uploaded patch set 3 10/19/20, 21:23

  14. Oliver Klee voted on patch set 3 CR +1 10/19/20, 21:24

  15. Daniel Goerz uploaded patch set 4 10/19/20, 21:35

  16. Daniel Goerz voted on patch set 4 V +1 CR +1 10/19/20, 21:35

  17. TYPO3com voted on patch set 3 V +1 10/19/20, 21:38 Completed build in 14m 53s on Mon, 19 Oct, 09:38 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6671

  18. TYPO3com voted on patch set 4 V +1 10/19/20, 21:50 Completed build in 14m 30s on Mon, 19 Oct, 09:50 PM Test Summary: 73838 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6672

  19. Oliver Klee voted on patch set 4 CR +1 10/19/20, 21:50

  20. Benni Mack voted on patch set 4 V +2 CR +2 10/20/20, 08:00

  21. Benni Mack merged patch set 5 10/20/20, 08:00