66157[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Controller
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+4 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+7 −6
- typo3/sysext/backend/Classes/Controller/File/ThumbnailController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/SuggestWizardController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php3+2 −1
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+6 −6
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+9 −9
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/HelpController.php+1 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+2 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+5 −4
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+1 −1
Review log 1721
-
Daniel Goerz uploaded patch set 1 10/17/20, 09:05
-
Daniel Goerz wrote 10/17/20, 09:05
Topic set to phpstan -
Daniel Goerz commented on patch set 1 10/17/20, 09:13
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65466 -
TYPO3com voted on patch set 1 V +1 10/17/20, 09:16 Completed build in 11m 45s on Sat, 17 Oct, 09:16 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6595
-
Oliver Klee voted on patch set 1 CR +1 10/17/20, 09:18
-
Daniel Goerz uploaded patch set 2 10/17/20, 13:16
-
Daniel Goerz voted on patch set 2 V +1 CR +1 10/17/20, 13:16
-
Oliver Klee voted on patch set 2 CR +1 10/17/20, 13:20
-
TYPO3com voted on patch set 2 V +1 10/17/20, 13:48 Completed build in 14m 38s on Sat, 17 Oct, 01:48 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6621
-
Benni Mack commented on patch set 2 10/19/20, 18:35
TableController.php:602is_countable is a function that was introduced in PHP 7.3 -
Christian Kuhn commented on patch set 2 CR -1 10/19/20, 18:42
TableController.php:602Replygood catch. symfony/polyfill-php73 brings it, but it is an indirect dependency and i think we shouldn't make it an explicit dependency just for this case, especially not for 10.4 (and in master it may resolve itself soon if we raise to >=7.4) -
Daniel Goerz commented on patch set 2 V 0 CR 0 10/19/20, 21:21
TableController.php:602Reply UnresolvedNice one. is_array() should do. -
Daniel Goerz uploaded patch set 3 10/19/20, 21:23
-
Oliver Klee voted on patch set 3 CR +1 10/19/20, 21:24
-
Daniel Goerz uploaded patch set 4 10/19/20, 21:35
-
Daniel Goerz voted on patch set 4 V +1 CR +1 10/19/20, 21:35
-
TYPO3com voted on patch set 3 V +1 10/19/20, 21:38 Completed build in 14m 53s on Mon, 19 Oct, 09:38 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6671
-
TYPO3com voted on patch set 4 V +1 10/19/20, 21:50 Completed build in 14m 30s on Mon, 19 Oct, 09:50 PM Test Summary: 73838 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6672
-
Oliver Klee voted on patch set 4 CR +1 10/19/20, 21:50
-
Benni Mack voted on patch set 4 V +2 CR +2 10/20/20, 08:00
-
Benni Mack merged patch set 5 10/20/20, 08:00