66158[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Form
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Daniel Goerz +2
- Anja Leichsenring +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 30
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+7 −7
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+6 −6
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+12 −12
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php2+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldWizard/DefaultLanguageDifferences.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageContent.php+2 −2
Show 10 more files
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageThumbnails.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+3 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseParentPageRow.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTypesShowitem.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+1 −1
Review log 1519
-
Daniel Goerz uploaded patch set 1 10/17/20, 09:12
-
Daniel Goerz wrote 10/17/20, 09:12
Topic set to phpstan -
Daniel Goerz commented on patch set 1 10/17/20, 09:14
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65466 -
Oliver Klee voted on patch set 1 CR +1 10/17/20, 09:20
-
TYPO3com voted on patch set 1 V +1 10/17/20, 09:37 Completed build in 24m 20s on Sat, 17 Oct, 09:37 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6599
-
Daniel Goerz uploaded patch set 2 10/17/20, 13:09
-
Daniel Goerz voted on patch set 2 V +1 CR +1 10/17/20, 13:09
-
Oliver Klee voted on patch set 2 CR +1 10/17/20, 13:20
-
TYPO3com voted on patch set 2 V +1 10/17/20, 13:43 Completed build in 32m 10s on Sat, 17 Oct, 01:43 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6620
-
Christian Kuhn commented on patch set 2 10/19/20, 19:27
SelectMultipleSideBySideElement.php:1623rd string cast is obsolete since appendValueToLabelInDebugMode() has been changed to :string -
Christian Kuhn uploaded patch set 3 10/19/20, 19:30
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/19/20, 19:30
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 10/19/20, 19:31
-
TYPO3com voted on patch set 3 V -1 10/19/20, 19:58 Completed build in 19m 55s on Mon, 19 Oct, 07:58 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6668
-
Oliver Klee voted on patch set 3 CR +1 10/19/20, 20:01
-
TYPO3com voted on patch set 3 V +1 10/19/20, 20:18 Completed build in 59m 14s on Mon, 19 Oct, 08:18 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6668
-
Daniel Goerz commented on patch set 3 10/19/20, 21:37
SelectMultipleSideBySideElement.php:162Reply UnresolvedAh, thanks, I somehow missed that one! -
Daniel Goerz voted on patch set 3 V +2 CR +2 10/19/20, 21:37
-
Daniel Goerz merged patch set 4 10/19/20, 21:37