Review main Merged

66158[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Form

Daniel Goerz CR +2 V +2 Normal +75 −73 updated 10/19/20, 21:37

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 30

Show 10 more files

Review log 1519

  1. Daniel Goerz uploaded patch set 1 10/17/20, 09:12

  2. Daniel Goerz wrote 10/17/20, 09:12

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 10/17/20, 09:14

  4. Oliver Klee voted on patch set 1 CR +1 10/17/20, 09:20

  5. TYPO3com voted on patch set 1 V +1 10/17/20, 09:37 Completed build in 24m 20s on Sat, 17 Oct, 09:37 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6599

  6. Daniel Goerz uploaded patch set 2 10/17/20, 13:09

  7. Daniel Goerz voted on patch set 2 V +1 CR +1 10/17/20, 13:09

  8. Oliver Klee voted on patch set 2 CR +1 10/17/20, 13:20

  9. TYPO3com voted on patch set 2 V +1 10/17/20, 13:43 Completed build in 32m 10s on Sat, 17 Oct, 01:43 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6620

  10. Christian Kuhn commented on patch set 2 10/19/20, 19:27

    SelectMultipleSideBySideElement.php:162

    3rd string cast is obsolete since appendValueToLabelInDebugMode() has been changed to :string
  11. Christian Kuhn uploaded patch set 3 10/19/20, 19:30

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 10/19/20, 19:30

  13. Anja Leichsenring voted on patch set 3 V +1 CR +1 10/19/20, 19:31

  14. TYPO3com voted on patch set 3 V -1 10/19/20, 19:58 Completed build in 19m 55s on Mon, 19 Oct, 07:58 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6668

  15. Oliver Klee voted on patch set 3 CR +1 10/19/20, 20:01

  16. TYPO3com voted on patch set 3 V +1 10/19/20, 20:18 Completed build in 59m 14s on Mon, 19 Oct, 08:18 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6668

  17. Daniel Goerz commented on patch set 3 10/19/20, 21:37

    SelectMultipleSideBySideElement.php:162 Reply Unresolved

    Ah, thanks, I somehow missed that one!
  18. Daniel Goerz voted on patch set 3 V +2 CR +2 10/19/20, 21:37

  19. Daniel Goerz merged patch set 4 10/19/20, 21:37