66159[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Tree
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+6 −2
- typo3/sysext/backend/Classes/Tree/View/BrowseTreeView.php+2 −2
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php+8 −9
- typo3/sysext/backend/Classes/Tree/View/PageMovingPagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+3 −3
- typo3/sysext/backend/Classes/Tree/SortedTreeNodeCollection.php+1 −1
- typo3/sysext/backend/Classes/Tree/TreeNode.php+6 −2
Review log 1215
-
Daniel Goerz uploaded patch set 1 10/17/20, 09:16
-
Daniel Goerz wrote 10/17/20, 09:17
Topic set to phpstan -
Daniel Goerz commented on patch set 1 10/17/20, 09:18
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65466 -
TYPO3com voted on patch set 1 V +1 10/17/20, 09:44 Completed build in 18m 34s on Sat, 17 Oct, 09:44 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6601
-
Daniel Goerz uploaded patch set 2 10/17/20, 11:29
-
Daniel Goerz voted on patch set 2 V +1 CR +1 10/17/20, 11:37
-
Daniel Goerz commented on patch set 2 10/17/20, 11:40
Still one error remaining but that one is not easily fixable. Suggest to merge patch as is and tackle the remeining error in a dedicated patch. Line Renderer/UnorderedListTreeRenderer.php 64 Parameter #1 $node of method TYPO3\CMS\Backend\Tree\Renderer\UnorderedListTreeRenderer::renderNode() expects TYPO3\CMS\Backend\Tree\TreeRepresentationNode, TYPO3\CMS\Backend\Tree\TreeNode given. -
TYPO3com voted on patch set 2 V +1 10/17/20, 11:42 Completed build in 12m 50s on Sat, 17 Oct, 11:42 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6606
-
Oliver Klee voted on patch set 2 CR +1 10/17/20, 13:22
-
Daniel Goerz uploaded patch set 3 10/19/20, 21:49
-
Daniel Goerz voted on patch set 3 V +1 CR +1 10/19/20, 21:49
-
TYPO3com voted on patch set 3 V +1 10/19/20, 22:14 Completed build in 15m 42s on Mon, 19 Oct, 10:14 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6675
-
Oliver Klee voted on patch set 3 CR +1 10/20/20, 10:45
-
Benni Mack voted on patch set 3 V +2 CR +2 10/22/20, 20:51
-
Benni Mack merged patch set 4 10/22/20, 20:51