Review main Merged

66159[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Tree

Daniel Goerz CR +2 V +2 Easy +27 −20 updated 10/22/20, 20:51

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1215

  1. Daniel Goerz uploaded patch set 1 10/17/20, 09:16

  2. Daniel Goerz wrote 10/17/20, 09:17

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 10/17/20, 09:18

  4. TYPO3com voted on patch set 1 V +1 10/17/20, 09:44 Completed build in 18m 34s on Sat, 17 Oct, 09:44 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6601

  5. Daniel Goerz uploaded patch set 2 10/17/20, 11:29

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 10/17/20, 11:37

  7. Daniel Goerz commented on patch set 2 10/17/20, 11:40

    Still one error remaining but that one is not easily fixable. Suggest to merge patch as is and tackle the remeining error in a dedicated patch. Line Renderer/UnorderedListTreeRenderer.php 64 Parameter #1 $node of method TYPO3\CMS\Backend\Tree\Renderer\UnorderedListTreeRenderer::renderNode() expects TYPO3\CMS\Backend\Tree\TreeRepresentationNode, TYPO3\CMS\Backend\Tree\TreeNode given.
  8. TYPO3com voted on patch set 2 V +1 10/17/20, 11:42 Completed build in 12m 50s on Sat, 17 Oct, 11:42 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6606

  9. Oliver Klee voted on patch set 2 CR +1 10/17/20, 13:22

  10. Daniel Goerz uploaded patch set 3 10/19/20, 21:49

  11. Daniel Goerz voted on patch set 3 V +1 CR +1 10/19/20, 21:49

  12. TYPO3com voted on patch set 3 V +1 10/19/20, 22:14 Completed build in 15m 42s on Mon, 19 Oct, 10:14 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6675

  13. Oliver Klee voted on patch set 3 CR +1 10/20/20, 10:45

  14. Benni Mack voted on patch set 3 V +2 CR +2 10/22/20, 20:51

  15. Benni Mack merged patch set 4 10/22/20, 20:51