Review main Merged

66160[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend View

Daniel Goerz CR +2 V +2 Easy +27 −20 updated 10/19/20, 13:55

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 810

  1. Daniel Goerz uploaded patch set 1 10/17/20, 09:20

  2. Daniel Goerz commented on patch set 1 10/17/20, 09:20

  3. Daniel Goerz wrote 10/17/20, 09:21

    Topic set to phpstan
  4. TYPO3com voted on patch set 1 V +1 10/17/20, 10:00 Completed build in 34m 11s on Sat, 17 Oct, 10:00 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6604

  5. Daniel Goerz uploaded patch set 2 10/17/20, 10:42

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 10/17/20, 10:43

  7. TYPO3com voted on patch set 2 V +1 10/17/20, 10:54 Completed build in 12m 01s on Sat, 17 Oct, 10:54 AM Test Summary: 73810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6605

  8. Oliver Klee voted on patch set 2 CR +1 10/17/20, 13:22

  9. Benni Mack voted on patch set 2 V +2 CR +2 10/19/20, 13:55

  10. Benni Mack merged patch set 3 10/19/20, 13:55