Review main Merged

66161[TASK] Deprecate last arguments of wrapClickMenuOnIcon()

Daniel Goerz CR +2 V +2 Normal +94 −14 updated 10/19/20, 18:36

Commit message

BackendUtility::wrapClickMenuOnIcon() has a boolean flag
to let the method return an array with tag parameters
instead of a fully build HTML tag as string.

As this are two completely different things and cause
problems when analysing return types it should not be
done in the same method.

Calling BackendUtility::wrapClickMenuOnIcon() with the
7th and last argument $returnTagParameters set to true
has been deprecated alongside the 5th and 6th arguments
that are already unused.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1422

  1. Daniel Goerz uploaded patch set 1 10/17/20, 12:27

  2. Daniel Goerz wrote 10/17/20, 12:27

    Topic set to phpstan
  3. Daniel Goerz uploaded patch set 2 10/17/20, 12:29

  4. Daniel Goerz uploaded patch set 3 10/17/20, 12:30

  5. Daniel Goerz uploaded patch set 4 10/17/20, 12:30

  6. Daniel Goerz uploaded patch set 5 10/17/20, 12:36

  7. Daniel Goerz uploaded patch set 6 10/17/20, 12:38

  8. TYPO3com voted on patch set 1 V +1 10/17/20, 12:41 Completed build in 14m 36s on Sat, 17 Oct, 12:41 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6607

  9. TYPO3com voted on patch set 2 V -1 10/17/20, 12:45 Completed build in 15m 36s on Sat, 17 Oct, 12:45 PM Test Summary: 1 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6608

  10. TYPO3com voted on patch set 3 V +1 10/17/20, 12:49 Completed build in 13m 40s on Sat, 17 Oct, 12:49 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6609

  11. TYPO3com voted on patch set 4 V -1 10/17/20, 12:54 Completed build in 19m 05s on Sat, 17 Oct, 12:54 PM Test Summary: 1 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6610

  12. TYPO3com voted on patch set 5 V -1 10/17/20, 13:03 Completed build in 18m 40s on Sat, 17 Oct, 01:03 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6612

  13. Daniel Goerz commented on patch set 7 10/17/20, 13:06

    Published edit on patch set 6.
  14. TYPO3com voted on patch set 6 V -1 10/17/20, 13:20 Completed build in 32m 18s on Sat, 17 Oct, 01:20 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6614

  15. Oliver Klee voted on patch set 7 CR +1 10/17/20, 13:24

  16. TYPO3com voted on patch set 7 V +1 10/17/20, 13:39 Completed build in 27m 57s on Sat, 17 Oct, 01:39 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6619

  17. Daniel Goerz uploaded patch set 8 10/18/20, 12:15

  18. TYPO3com voted on patch set 8 V +1 10/18/20, 12:27 Completed build in 12m 21s on Sun, 18 Oct, 12:27 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6628

  19. Oliver Klee voted on patch set 8 CR +1 10/18/20, 12:41

  20. Christian Kuhn voted on patch set 8 V +1 CR +1 10/19/20, 18:35

  21. Anja Leichsenring voted on patch set 8 V +2 CR +2 10/19/20, 18:35

  22. Anja Leichsenring merged patch set 9 10/19/20, 18:36