Review main Merged Breaking

66162[!!!][TASK] Drop resizable textarea user setting

Christian Kuhn CR +2 V +2 Normal +50 −51 updated 10/19/20, 11:35

Commit message

The 'Make textareas resizable' setting is quite ancient.
The patch drops this option from the user settings and
enables 'growing' text areas by default. To prevent text
areas from growing indefinitely, the user setting
'max height' with a default of 500px is kept.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 812

  1. Christian Kuhn uploaded patch set 1 10/17/20, 12:32

  2. Christian Kuhn uploaded patch set 2 10/17/20, 12:36

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 10/17/20, 12:52

  4. TYPO3com voted on patch set 1 V +1 10/17/20, 12:58 Completed build in 23m 06s on Sat, 17 Oct, 12:58 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6611

  5. TYPO3com voted on patch set 2 V -1 10/17/20, 13:08 Completed build in 24m 10s on Sat, 17 Oct, 01:08 PM Test Summary: 1 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6613

  6. TYPO3com voted on patch set 2 V +1 10/17/20, 15:02 Completed build in 2h 42m 25s on Sat, 17 Oct, 03:02 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6613

  7. Oliver Klee commented on patch set 3 10/17/20, 18:00

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 10/17/20, 18:13 Completed build in 13m 03s on Sat, 17 Oct, 06:13 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6622

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 10/19/20, 09:28

  10. Markus Klein voted on patch set 3 V +1 CR +1 10/19/20, 11:28

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 10/19/20, 11:35

  12. Christian Kuhn merged patch set 4 10/19/20, 11:35