Review 10.4 Merged

66168[BUGFIX] Workspace and reference index fixes

Christian Kuhn CR +2 V +2 Hard +173 −247 updated 10/19/20, 17:42

Commit message

This drops all left over calls that suppress the refindex
integrity checks in DataHandler functional tests, except those
within ManyToMany tests: This area needs more work before the
reference index can be fixed.

Two bugs indirectly related to the reference index are fixed
along the way, those can't be separated as standalone patches:

* When a translated page is deleted in workspaces, the
  DataHandler deleted live records on this page, too. This
  is fixed by adding a proper db restriction. This also
  fixes the reference index state in this scenario.

* When publishing a delete placeholder that has inline children,
  workspace delete placeholders are created for the children, which
  is wrong. This happens because the user is not set to the live
  workspace during the publish operation. Temporarily changing the
  user workspace to live not only fixes the reference index, but
  does not create the bogus inline children placeholder records
  anymore, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 2

Files 48

Show 28 more files

Review log 59

  1. Christian Kuhn uploaded patch set 1 10/18/20, 15:34

  2. TYPO3com voted on patch set 1 V -1 10/18/20, 15:45 Completed build in 11m 35s on Sun, 18 Oct, 03:45 PM Test Summary: 120 of 75332 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-638

  3. Christian Kuhn uploaded patch set 2 10/19/20, 11:18

  4. TYPO3com voted on patch set 2 V -1 10/19/20, 11:32 Completed build in 13m 27s on Mon, 19 Oct, 11:32 AM Test Summary: 74847 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-639

  5. Christian Kuhn uploaded patch set 3 10/19/20, 11:33

  6. TYPO3com voted on patch set 3 V -1 10/19/20, 11:50 Completed build in 17m 35s on Mon, 19 Oct, 11:50 AM Test Summary: 1 of 73750 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-640

  7. TYPO3com voted on patch set 3 V +1 10/19/20, 12:12 Completed build in 57m 09s on Mon, 19 Oct, 12:12 PM Test Summary: 74847 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-640

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 10/19/20, 17:42

  9. Christian Kuhn merged patch set 4 10/19/20, 17:42