Review main Merged Breaking

66169[!!!][TASK] Return moved PID when overlaying versioned records

Benni Mack CR +2 V +2 Hard +229 −71 updated 10/19/20, 18:12

Commit message

In the past, the API methods:
* PageRepository->versionOL()
* BackendUtility::workspaceOL()

returned the PID of the moved record in a workspace in the field
_ORIG_PID and the live record value in "pid".

The methods "fixVersioningPid()" were used to return the
moved PID (of the versioned records) and set the "_ORIG_PID"
to the value of the live record.

This inconsistency can be overcome by simply using workspaceOL
returning the newly moved location as "pid" and keep the "_ORIG_pid"
of the live record for later purposes.

This way, fixVersioningPid is not needed anymore, if workspaceOL/versionOL
is applied. TYPO3 Core is not using the fixVersioningPid methods
anymore now and they are marked as deprecated.

As this is a breaking change ("behavior of overlay and value of _ORIG_pid")
an RST explains the new behavior.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 1320

  1. Benni Mack uploaded patch set 1 10/18/20, 18:56

  2. TYPO3com voted on patch set 1 V -1 10/18/20, 19:10 Completed build in 13m 24s on Sun, 18 Oct, 07:10 PM Test Summary: 84 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6635

  3. Benni Mack uploaded patch set 2 10/18/20, 20:02

  4. TYPO3com voted on patch set 2 V +1 10/18/20, 20:25 Completed build in 22m 47s on Sun, 18 Oct, 08:25 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6636

  5. Benni Mack uploaded patch set 3 10/19/20, 10:18

  6. TYPO3com voted on patch set 3 V +1 10/19/20, 10:32 Completed build in 13m 30s on Mon, 19 Oct, 10:32 AM Test Summary: 73809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6649

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 10/19/20, 14:10

  8. Daniel Goerz commented on patch set 4 10/19/20, 14:38

    Published edit on patch set 3.
  9. Daniel Goerz voted on patch set 4 CR +1 10/19/20, 14:38

  10. TYPO3com voted on patch set 4 V +1 10/19/20, 14:52 Completed build in 13m 36s on Mon, 19 Oct, 02:52 PM Test Summary: 73809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6655

  11. Anja Leichsenring updated the commit message in patch set 5 10/19/20, 17:43

  12. Anja Leichsenring commented on patch set 6 10/19/20, 17:46

    Published edit on patch set 5.
  13. Anja Leichsenring commented on patch set 7 10/19/20, 17:52

    Published edit on patch set 6.
  14. Anja Leichsenring voted on patch set 7 V +1 CR +1 10/19/20, 17:53

  15. Christian Kuhn voted on patch set 7 V +1 CR +1 10/19/20, 18:00

  16. TYPO3com voted on patch set 5 V +1 10/19/20, 18:00 Completed build in 15m 51s on Mon, 19 Oct, 06:00 PM Test Summary: 73809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6660

  17. TYPO3com voted on patch set 6 V +1 10/19/20, 18:05 Completed build in 14m 12s on Mon, 19 Oct, 06:05 PM Test Summary: 73809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6661

  18. TYPO3com voted on patch set 7 V +1 10/19/20, 18:11 Completed build in 16m 32s on Mon, 19 Oct, 06:11 PM Test Summary: 73809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6662

  19. Christian Kuhn voted on patch set 7 V +2 CR +2 10/19/20, 18:12

  20. Christian Kuhn merged patch set 8 10/19/20, 18:12