66170[TASK] Centralize Extension Installation Paths
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 14
- typo3/sysext/core/Classes/Package/Exception/InvalidInstallationPathException.phpnew+27 −0
- typo3/sysext/core/Classes/Package/PackageInstallationLocations.phpnew+133 −0
- typo3/sysext/core/Tests/Unit/Package/PackageInstallationLocationsTest.phpnew+51 −0
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+7 −6
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+3 −2
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+0 −47
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+2 −1
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+21 −46
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+2 −7
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+2 −19
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+4 −5
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+3 −17
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+2 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+0 −32
Review log 1525
-
Benni Mack uploaded patch set 1 10/18/20, 21:34
-
TYPO3com voted on patch set 1 V -1 10/18/20, 21:54 Completed build in 20m 01s on Sun, 18 Oct, 09:54 PM Test Summary: 18 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6637
-
Benni Mack uploaded patch set 2 10/19/20, 06:35
-
TYPO3com voted on patch set 2 V -1 10/19/20, 06:49 Completed build in 13m 28s on Mon, 19 Oct, 06:49 AM Test Summary: 12 of 74297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6644
-
Benni Mack uploaded patch set 3 10/22/20, 20:59
-
TYPO3com voted on patch set 3 V -1 10/22/20, 21:14 Completed build in 14m 11s on Thu, 22 Oct, 09:14 PM Test Summary: 12 of 73943 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6813
-
Benni Mack uploaded patch set 4 12/10/20, 22:38
-
Benni Mack updated the commit message in patch set 5 12/10/20, 22:50
-
TYPO3com voted on patch set 4 V -1 12/10/20, 22:57 Completed build in 14m 21s on Thu, 10 Dec, 10:57 PM Test Summary: 4 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8042
-
TYPO3com voted on patch set 5 V -1 12/10/20, 23:07 Completed build in 16m 47s on Thu, 10 Dec, 11:07 PM Test Summary: 4 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8044
-
Benni Mack uploaded patch set 6 12/11/20, 12:24
-
TYPO3com voted on patch set 6 V -1 12/11/20, 12:33 Completed build in 09m 21s on Fri, 11 Dec, 12:33 PM Test Summary: 4 of 32658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8063
-
Benni Mack uploaded patch set 7 12/11/20, 18:33
-
TYPO3com voted on patch set 7 V -1 12/11/20, 18:34 Completed build in 22s on Fri, 11 Dec, 06:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8086
-
Benni Mack uploaded patch set 8 12/11/20, 18:44
-
TYPO3com voted on patch set 8 V +1 12/11/20, 18:54 Completed build in 09m 41s on Fri, 11 Dec, 06:54 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8087
-
Oliver Klee commented on patch set 9 12/11/20, 20:11
Published edit on patch set 8. -
TYPO3com voted on patch set 9 V -1 12/11/20, 20:26 Completed build in 14m 16s on Fri, 11 Dec, 08:26 PM Test Summary: 7 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8093
-
Oliver Klee commented on patch set 9 12/12/20, 19:17
I don't think that the breakage is related to my change (adding strict mode to one PHP file). -
Benni Mack commented on patch set 9 12/13/20, 19:31
Reply
No, I will take care of the breaking tests. Thank you, Oli 👍 -
TYPO3com voted on patch set 9 V +1 12/13/20, 19:34 Completed build in 23h 36m 29s on Sun, 13 Dec, 07:33 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8093
-
Oli Bartsch voted on patch set 9 V +1 CR +1 12/14/20, 09:10
-
Christian Kuhn commented on patch set 9 CR -1 12/14/20, 12:07
I would prefer if PackageInstallationPath is not static - This is much easier to mock in usages, then, so lower dependencies like Environment does not need to be faked. -
Oliver Klee wrote 12/18/20, 21:39
Removed reviewer Oliver Klee. -
Benni Mack abandoned the change 09/07/21, 18:52
won't do