Review main Merged

66174[BUGFIX] Return empty array when user can't be found

Tymoteusz Motylewski CR +2 V +2 Easy +11 −3 updated 10/19/20, 18:18

Commit message

FrontendUserRepository::fetchUserInformationByEmail now returns
empty array when there is no user with given email.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1418

  1. Tymoteusz Motylewski uploaded patch set 1 10/19/20, 11:45

  2. TYPO3com voted on patch set 1 V +1 10/19/20, 12:00 Completed build in 14m 25s on Mon, 19 Oct, 12:00 PM Test Summary: 73815 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6651

  3. Oliver Klee updated the commit message in patch set 2 10/19/20, 12:23

  4. Oliver Klee updated the commit message in patch set 3 10/19/20, 12:24

  5. Oliver Klee voted on patch set 3 CR +1 10/19/20, 12:25

  6. Oliver Klee commented on patch set 3 CR 0 10/19/20, 12:25

    Should we document this behavior in the method PHPDoc?
  7. TYPO3com voted on patch set 2 V +1 10/19/20, 12:37 Completed build in 13m 07s on Mon, 19 Oct, 12:37 PM Test Summary: 73815 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6652

  8. TYPO3com voted on patch set 3 V +1 10/19/20, 12:40 Completed build in 16m 33s on Mon, 19 Oct, 12:40 PM Test Summary: 73815 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6653

  9. Georg Ringer voted on patch set 3 V +1 CR +1 10/19/20, 15:12

  10. Oliver Klee commented on patch set 3 CR -1 10/19/20, 15:22

    temporary -1 so this does not get merged until we have decided whether we need to document this case in the PHPDoc.
  11. Tymoteusz Motylewski uploaded patch set 4 10/19/20, 15:28

  12. Tymoteusz Motylewski commented on patch set 4 10/19/20, 15:29

    here you go Oliver :)
  13. TYPO3com voted on patch set 4 V +1 10/19/20, 15:40 Completed build in 11m 39s on Mon, 19 Oct, 03:40 PM Test Summary: 73815 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6657

  14. Oliver Klee commented on patch set 4 CR +1 10/19/20, 15:46

    Thanks! <3
  15. Christian Kuhn voted on patch set 4 V +1 CR +1 10/19/20, 18:15

  16. Anja Leichsenring voted on patch set 4 V +2 CR +2 10/19/20, 18:15

  17. Anja Leichsenring merged patch set 5 10/19/20, 18:15

  18. Anja Leichsenring commented on patch set 5 10/19/20, 18:18

    no backport to v9, the classes don't even exist there.