Review main Merged

66179[FEATURE] Improved Email Validation

Georg Ringer CR +2 V +2 Normal +60 −2 updated 10/20/20, 08:33

Commit message

The method :php`\TYPO3\CMS\Core\Utility\GeneralUtility::validEmail`
is used to validate a given email address through the core
and TYPO3 extensions.

The validation can now be configured by providing the used
validators to be used in the LocalConfiguration.php or
AdditionalConfiguration.php.

Example:

   $GLOBALS['TYPO3_CONF_VARS']['MAIL']['validators'] = [
     \Egulias\EmailValidator\Validation\RFCValidation::class,
     \Egulias\EmailValidator\Validation\DNSCheckValidation::class'
   ];

The RFCValidation validator is still be used as default.

Furthermore, following validators are available:

- Egulias\EmailValidator\Validation\DNSCheckValidation
- Egulias\EmailValidator\Validation\SpoofCheckValidation
- Egulias\EmailValidator\Validation\NoRFCWarningsValidation

It is also possible to provide own validators which must implement
the Egulias\EmailValidator\Validation\EmailValidation interface.

If multiple validators are provided, each validator must return TRUE.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1012

  1. Georg Ringer uploaded patch set 1 10/19/20, 19:17

  2. Georg Ringer commented on patch set 1 10/19/20, 19:17

    This change is ready for review.
  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/19/20, 19:35

  4. TYPO3com voted on patch set 1 V +1 10/19/20, 19:44 Completed build in 23m 05s on Mon, 19 Oct, 07:44 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6667

  5. Thomas Löffler voted on patch set 1 CR +1 10/20/20, 07:02

  6. Oli Bartsch uploaded patch set 2 10/20/20, 08:12

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 10/20/20, 08:16

  8. Josef Glatz voted on patch set 2 CR +1 10/20/20, 08:17

  9. Daniel Goerz commented on patch set 2 V +1 CR +1 10/20/20, 08:21

    Thanks Oli, ws about to make the same changes :)
  10. TYPO3com voted on patch set 2 V +1 10/20/20, 08:29 Completed build in 16m 32s on Tue, 20 Oct, 08:29 AM Test Summary: 73477 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6679

  11. Daniel Goerz voted on patch set 2 V +2 CR +2 10/20/20, 08:33

  12. Daniel Goerz merged patch set 3 10/20/20, 08:33